Attachment 35260 Details for Bug 13531 – Bug 13531: QA follow up

[patch] Bug 13531: QA follow up

Bug-13531-QA-follow-up.patch (text/plain), 1.33 KB, created by Thomas Wright on 2015-01-14 20:22:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Wright

Created: 2015-01-14 20:22:21 UTC

Size: 1.33 KB

patch

obsolete

>From a4703f22e150cfbeb7af5810590458f3f6eee560 Mon Sep 17 00:00:00 2001
>From: Thomas <tomsStudy@gmail.com>
>Date: Wed, 14 Jan 2015 20:20:36 +0000
>Subject: [PATCH] Bug 13531: QA follow up
>
>A minor QA comment.
>
>::: misc/migration_tools/bulkmarcimport.pl
>@@ +271,5 @@
>>          my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( $query, 0, 3, [$server] );
>> +        # changed to warn so able to continue with one broken record
>> +        if ( defined $error ) {
>> +            warn "unable to search the database for duplicates : $error";
>> +            next;
>
>For consistency with the rest of the script, should this perhaps be:
>
>next RECORD;
>---
> misc/migration_tools/bulkmarcimport.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index e6fa37f..c994833 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -272,7 +272,7 @@ RECORD: while (  ) {
>         # changed to warn so able to continue with one broken record
>         if ( defined $error ) {
>             warn "unable to search the database for duplicates : $error";
>-            next;
>+            next RECORD;
>         }
>         $debug && warn "$query $server : $totalhits";
>         if ( $results && scalar(@$results) == 1 ) {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13531: 35133 | 35147 | 35260 | 35295 | 35486 | 36625 | 37044 | 37045 | 37046 | 37047