Bugzilla – Attachment 35285 Details for
Bug 13584
Able to view menu for Purchase Suggestions even when user does not have permission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission
SIGNED-OFF-Bug-13584---Able-to-view-menu-for-Purch.patch (text/plain), 1.93 KB, created by
Katrin Fischer
on 2015-01-15 06:35:00 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-01-15 06:35:00 UTC
Size:
1.93 KB
patch
obsolete
>From 2583c720f5e0f2906d521b098917c0b2e9e20fcc Mon Sep 17 00:00:00 2001 >From: Thomas <tomsStudy@gmail.com> >Date: Wed, 14 Jan 2015 23:26:36 +0000 >Subject: [PATCH] [SIGNED OFF] Bug 13584 - Able to view menu for Purchase > Suggestions even when user does not have permission > >Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken > >Testing Plan: > >-Search for a patron with an account that does not have the 'borrowers' permission >*Purchase suggestions item should not be seen in the menu. > >-Change the accounts permissions so they have the 'borrowers' permission >*Purchase suggestions item should be present in the menu. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >The page requires borrowers permission, so the link should act accordingly. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index 2fe0a68..d93b494 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -83,7 +83,10 @@ > [% IF EnableBorrowerFiles %] > [% IF ( borrower_files ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/files.pl?borrowernumber=[% borrowernumber %]">Files</a></li> > [% END %] >- [% IF ( suggestionsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/purchase-suggestions.pl?borrowernumber=[% borrowernumber %]">Purchase suggestions</a></li> >+ >+ [% IF ( CAN_user_borrowers ) %] >+ [% IF ( suggestionsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/purchase-suggestions.pl?borrowernumber=[% borrowernumber %]">Purchase suggestions</a></li> >+ [% END %] > </ul></div> > [% END %] > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13584
:
35267
|
35285
|
35298
|
35299