Attachment 35298 Details for Bug 13584 – Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission

[patch] Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission

Bug-13584---Able-to-view-menu-for-Purchase-Suggest.patch (text/plain), 2.23 KB, created by Jonathan Druart on 2015-01-15 11:08:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-01-15 11:08:12 UTC

Size: 2.23 KB

patch

obsolete

>From 8da920854f7f2ba35a3c3ee52ce184d36bf26f72 Mon Sep 17 00:00:00 2001
>From: Thomas <tomsStudy@gmail.com>
>Date: Wed, 14 Jan 2015 23:26:36 +0000
>Subject: [PATCH] Bug 13584 - Able to view menu for Purchase Suggestions even
> when user does not have permission
>
>Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken
>
>Testing Plan:
>
>-Search for a patron with an account that does not have the 'borrowers' permission
>*Purchase suggestions item should not be seen in the menu.
>
>-Change the accounts permissions so they have the 'borrowers' permission
>*Purchase suggestions item should be present in the menu.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>The page requires borrowers permission, so the link should act accordingly.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>Same problem for Fines, Circulation history, Notices and Statistics
>tabs.
>circ-menu.tt is only used from the Fines tab (which is not accessible),
>to it's not useful to add this check to it. But for the consistency, it
>makes sense. follow-up coming.
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index 2fe0a68..d93b494 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -83,7 +83,10 @@
>     [% IF EnableBorrowerFiles %]
>         [% IF ( borrower_files ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/files.pl?borrowernumber=[% borrowernumber %]">Files</a></li>
>     [% END %]
>-    [% IF (  suggestionsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/purchase-suggestions.pl?borrowernumber=[% borrowernumber %]">Purchase suggestions</a></li>
>+
>+    [% IF ( CAN_user_borrowers ) %]
>+        [% IF ( suggestionsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/purchase-suggestions.pl?borrowernumber=[% borrowernumber %]">Purchase suggestions</a></li>
>+    [% END %]
> </ul></div>
> [% END %]
> 
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13584: 35267 | 35285 | 35298 | 35299