Attachment 35342 Details for Bug 7380 – [Signed-off] Bug 10177 - whitespace is a valid password causing pernicious perturbations.

[patch] [Signed-off] Bug 10177 - whitespace is a valid password causing pernicious perturbations.

Signed-off-Bug-10177---whitespace-is-a-valid-passw.patch (text/plain), 1.63 KB, created by Marc Véron on 2015-01-18 08:38:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2015-01-18 08:38:51 UTC

Size: 1.63 KB

patch

obsolete

>From 0a1d4c713584bec3a538167004ceae422ca701b4 Mon Sep 17 00:00:00 2001
>From: Brandon <brandon_h27@hotmail.com>
>Date: Wed, 14 Jan 2015 22:30:01 +0000
>Subject: [PATCH] [Signed-off] Bug 10177 - whitespace is a valid password
> causing pernicious perturbations.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test plan:
>Go to your patron, go to change username and/or password. change
>password to whitespace, notice it is accepted, apply this patch,
>change password again, to whitespace, notice password is not valid.
>
>Tested with both patches together. Passwords with leading/trailing whitspaces are rejected as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>http://bugs.koha-community.org/show_bug.cgi?id=7380
>---
> .../intranet-tmpl/prog/en/modules/members/member-password.tt      |    5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
>index 96544e0..c394389 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
>@@ -9,7 +9,12 @@
>                 alert(_("Passwords do not match"));
>                 return false;
>             } else {
>+                if ($("input[name='newpassword']").val().match(/^\s*$/)) { 
>+                  alert(_("Password contains nothing except whitespace"));
>+                  return false;
>+              } else {
>                 return true;
>+}
>             }
>         });
>         $("body").on('click', "#fillrandom",function(e) {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 7380: 29697 | 33157 | 35222 | 35259 | 35342 | 37805 | 37806 | 38053 | 38055 | 38056 | 38067 | 38068 | 38090 | 38107 | 38108