Attachment 35352 Details for Bug 13583 – [SIGNED OFF] Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke

[patch] [SIGNED OFF] Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke

SIGNED-OFF-Bug-13583---Able-to-view-menu-for-Stati.patch (text/plain), 2.13 KB, created by Katrin Fischer on 2015-01-18 22:06:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-01-18 22:06:35 UTC

Size: 2.13 KB

patch

obsolete

>From f68b00918828997621502097782220fb169a3ab7 Mon Sep 17 00:00:00 2001
>From: Thomas <tomsStudy@gmail.com>
>Date: Wed, 14 Jan 2015 22:57:37 +0000
>Subject: [PATCH] [SIGNED OFF] Bug 13583 - Able to view menu for Statistics
> even when user does not have permission Added check for borrowers that stops
> the Statistics link being shown. This could be done through the css but that
> function currently appears to be broke
>
>Testing Plan:
>
>-Search for a patron with an account that does not have the 'borrowers' permission
>*Statistics should not be seen in the menu.
>
>-Change the accounts permissions so they have the 'borrowers' permission
>*Statistics should be present in the menu.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works as described.
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index 2fe0a68..4ad1949 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -79,7 +79,10 @@
>     [% IF ( EnhancedMessagingPreferences ) %]
> 	[% IF ( sentnotices ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/notices.pl?borrowernumber=[% borrowernumber %]">Notices</a></li>
>     [% END %]
>-    [% IF (  statisticsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/statistics.pl?borrowernumber=[% borrowernumber %]">Statistics</a></li>
>+    
>+    [% IF ( CAN_user_borrowers ) %]
>+        [% IF (  statisticsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/statistics.pl?borrowernumber=[% borrowernumber %]">Statistics</a></li>
>+    [% END %]
>     [% IF EnableBorrowerFiles %]
>         [% IF ( borrower_files ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/files.pl?borrowernumber=[% borrowernumber %]">Files</a></li>
>     [% END %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13583: 35266 | 35352 | 35379 | 35380 | 35381