Bugzilla – Attachment 35356 Details for
Bug 10177
Koha Accepts Seven "Space" Characters as a Valid Password
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10177 - whitespace is a valid password causing pernicious perturbations.
PASSED-QA-Bug-10177---whitespace-is-a-valid-passwo.patch (text/plain), 1.57 KB, created by
Katrin Fischer
on 2015-01-19 06:17:50 UTC
(
hide
)
Description:
[PASSED QA] Bug 10177 - whitespace is a valid password causing pernicious perturbations.
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-01-19 06:17:50 UTC
Size:
1.57 KB
patch
obsolete
>From 5532d8f55f7355a3974939d83cff0539008de6a8 Mon Sep 17 00:00:00 2001 >From: Brandon <brandon_h27@hotmail.com> >Date: Wed, 14 Jan 2015 22:30:01 +0000 >Subject: [PATCH] [PASSED QA] Bug 10177 - whitespace is a valid password > causing pernicious perturbations. >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: >Go to your patron, go to change username and/or password. change >password to whitespace, notice it is accepted, apply this patch, >change password again, to whitespace, notice password is not valid. > >Followed test plan. Patch behaves as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt >index 96544e0..6d27ad3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt >@@ -9,7 +9,12 @@ > alert(_("Passwords do not match")); > return false; > } else { >+ if ($("input[name='newpassword']").val().match(/^\s*$/)) { >+ alert(_("Password contains nothing except whitespace")); >+ return false; >+ } else { > return true; >+} > } > }); > $("body").on('click', "#fillrandom",function(e) { >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10177
:
35265
|
35320
|
35343
|
35344
| 35356 |
35357