Attachment 35374 Details for Bug 12637 – Bug 12637: UTF-8 problems when creating a patron list

[patch] Bug 12637: UTF-8 problems when creating a patron list

Bug-12637-UTF-8-problems-when-creating-a-patron-li.patch (text/plain), 1.87 KB, created by Marcel de Rooy on 2015-01-19 12:04:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-01-19 12:04:06 UTC

Size: 1.87 KB

patch

obsolete

>From aefc119ffffcfa60357e6870ea5aa3f2574a592c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 24 Jul 2014 10:51:19 +0200
>Subject: [PATCH] Bug 12637: UTF-8 problems when creating a patron list
>Content-Type: text/plain; charset=utf-8
>
>Encoding problems appear when creating a patron list from the patron search results page.
>
>Test plan:
>1. Perform a patron search in the patrons module
>2. Select one or more patrons
>3. Choose "Add selected patrons to: [ New list ]"
>4. Enter a patron list title with UTF-8 characters.
>5. The list will be created with bad encoding.
>6. Apply the patch and verify there is no bad encoding anymore.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Patch works fine.
>Note that I - very ironically - had to remove UTF8 characters from the commit
>message to apply and attach the patches with git/git-bz.
>Hopefully, an upgrade to a newer git version will resolve that too.
>---
> .../prog/en/modules/members/member.tt              |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>index 6e9ef78..f1f0fa8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>@@ -59,8 +59,8 @@ $(document).ready(function() {
>             borrowernumbers.push($(this).val());
>         });
>         var data = {
>-            add_to_patron_list: encodeURIComponent($("#add_to_patron_list").val()),
>-            new_patron_list: encodeURIComponent($("#new_patron_list").val()),
>+            add_to_patron_list: $("#add_to_patron_list").val(),
>+            new_patron_list: $("#new_patron_list").val(),
>             borrowernumbers: borrowernumbers
>         };
>         $.ajax({
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 12637: 30013 | 30455 | 35374