Attachment 35379 Details for Bug 13583 – Bug 13583 - Able to view menu for Statistics even when user does not have permission

[patch] Bug 13583 - Able to view menu for Statistics even when user does not have permission

Bug-13583---Able-to-view-menu-for-Statistics-even-.patch (text/plain), 2.11 KB, created by Jonathan Druart on 2015-01-19 13:08:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-01-19 13:08:09 UTC

Size: 2.11 KB

patch

obsolete

>From 8851fd26d0acbf4b359a7c098f2396adf1414117 Mon Sep 17 00:00:00 2001
>From: Thomas <tomsStudy@gmail.com>
>Date: Wed, 14 Jan 2015 22:57:37 +0000
>Subject: [PATCH] Bug 13583 - Able to view menu for Statistics even when user
> does not have permission
>
>Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke
>
>Testing Plan:
>
>-Search for a patron with an account that does not have the 'borrowers' permission
>*Statistics should not be seen in the menu.
>
>-Change the accounts permissions so they have the 'borrowers' permission
>*Statistics should be present in the menu.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works as described.
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index 2fe0a68..4ad1949 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -79,7 +79,10 @@
>     [% IF ( EnhancedMessagingPreferences ) %]
> 	[% IF ( sentnotices ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/notices.pl?borrowernumber=[% borrowernumber %]">Notices</a></li>
>     [% END %]
>-    [% IF (  statisticsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/statistics.pl?borrowernumber=[% borrowernumber %]">Statistics</a></li>
>+    
>+    [% IF ( CAN_user_borrowers ) %]
>+        [% IF (  statisticsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/statistics.pl?borrowernumber=[% borrowernumber %]">Statistics</a></li>
>+    [% END %]
>     [% IF EnableBorrowerFiles %]
>         [% IF ( borrower_files ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/files.pl?borrowernumber=[% borrowernumber %]">Files</a></li>
>     [% END %]
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13583: 35266 | 35352 | 35379 | 35380 | 35381