Bugzilla – Attachment 35570 Details for
Bug 13544
admin/auth_subfields_structure.pl does not compile in older perls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13544: Make it explicit that getauthtypes returns a hash ref
Bug-13544-Make-it-explicit-that-getauthtypes-retur.patch (text/plain), 1.31 KB, created by
Martin Renvoize (ashimema)
on 2015-01-28 08:03:15 UTC
(
hide
)
Description:
[PASSED QA] Bug 13544: Make it explicit that getauthtypes returns a hash ref
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2015-01-28 08:03:15 UTC
Size:
1.31 KB
patch
obsolete
>From 1cb602620f082c542680f5deb20546bb9e50d6f2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 9 Jan 2015 16:01:35 +0100 >Subject: [PATCH] Bug 13544: Make it explicit that getauthtypes returns a hash > ref > >Prior to perl 5.12 keys can only operate on a hash. > >Test plan: >With perl 5.10, access to admin/auth_subfields_structure.pl. >Without this patch, you get: >Type of arg 1 to keys must be hash (not subroutine entry) at >/home/koha/src/admin/auth_subfields_structure.pl line 102, near >"getauthtypes)" > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Confirmed problem and tested patch on a sandbox, signed off locally. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > admin/auth_subfields_structure.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/auth_subfields_structure.pl b/admin/auth_subfields_structure.pl >index 02eef5d..1a2ec15 100755 >--- a/admin/auth_subfields_structure.pl >+++ b/admin/auth_subfields_structure.pl >@@ -99,7 +99,7 @@ if ($op eq 'add_form') { > push @$authorised_values, 'itemtypes'; > > # build thesaurus categories list >- my @authtypes = (sort keys getauthtypes); >+ my @authtypes = (sort keys %{C4::Koha::getauthtypes()}); > > # build value_builder list > my @value_builder=(''); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13544
:
35088
|
35419
| 35570