Attachment 35577 Details for Bug 13142 – Bug 13142 - Change "mobile phone" label back to "other phone"

[patch] Bug 13142 - Change "mobile phone" label back to "other phone"

Bug-13142---Change-mobile-phone-label-back-to-othe.patch (text/plain), 7.25 KB, created by Marcel de Rooy on 2015-01-28 13:14:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-01-28 13:14:27 UTC

Size: 7.25 KB

patch

obsolete

>From 7e8431a864073489544e992dc61ff0d45e606a0c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 12 Nov 2014 14:42:37 -0500
>Subject: [PATCH] Bug 13142 - Change "mobile phone" label back to "other
> phone"
>Content-Type: text/plain; charset=utf-8
>
>Labeling a phone number field "mobile phone" eliminates the usefulness
>of having the labels "primary" and "secondary." Generic labels let the
>user populate the fields according to their importance rather than their
>type.
>
>To test I recommend editing a patron record so that the values in the
>patron record contain a label matching the table column:
>
>borrowers.phone : 555-555-1234 (primary - phone)
>borrowers.phonepro : 555-555-5678 (secondary - phonepro)
>borrowers.mobile : 555-555-9012 (other - mobile)
>
>View this patron's information in the various affected templates and
>verify that the labels correctly match the data:
>
> - OPAC "your personal details" (opac-memberentry.pl)
> - Submit changes to primary, secondary, and other phone via the OPAC.
> In the staff client, view the confirmation for those changes.
> - Patron details in the staff client (moremember.pl)
> - Patron entry/edit in the staff client (memberentrygen.pl)
> - Patron duplicate confirmation in the staff client
> (you can navigate directly to
> /members/moremember.pl?borrowernumber=XXXX&print=brief)
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/columns.def | 2 +-
> .../prog/en/modules/members/memberentrygen.tt | 2 +-
> .../prog/en/modules/members/members-update.tt | 4 ++--
> .../prog/en/modules/members/moremember-brief.tt | 4 ++--
> .../prog/en/modules/members/moremember.tt | 4 ++--
> .../bootstrap/en/modules/opac-memberentry.tt | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/columns.def b/koha-tmpl/intranet-tmpl/prog/en/columns.def
>index ec0fb56..636811d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/columns.def
>+++ b/koha-tmpl/intranet-tmpl/prog/en/columns.def
>@@ -18,7 +18,7 @@
> <field name="borrowers.country">Country</field>
> <field name="borrowers.phone">Primary phone</field>
> <field name="borrowers.phonepro">Secondary phone</field>
>-<field name="borrowers.mobile">Mobile phone</field>
>+<field name="borrowers.mobile">Other phone</field>
> <field name="borrowers.email">Primary email</field>
> <field name="borrowers.emailpro">Secondary email</field>
> <field name="borrowers.fax">Fax</field>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 95f42e6..83a7e0e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -607,7 +607,7 @@
> [% ELSE %]
> <label for="mobile">
> [% END %]
>- Mobile phone: </label>
>+ Other phone: </label>
> <input type="text" id="mobile" name="mobile" value="[% mobile %]" />
> 	 [% IF ( mandatorymobile ) %]Required[% END %]
> </li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>index 9231ef7..5d966df 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>@@ -28,8 +28,8 @@
> [% CASE 'zipcode' %]Zip code
> [% CASE 'country' %]Country
> [% CASE 'email' %]Email
>-[% CASE 'phone' %]Primary Phone
>-[% CASE 'mobile' %]Primary Mobile Phone
>+[% CASE 'phone' %]Primary phone
>+[% CASE 'mobile' %]Other phone
> [% CASE 'fax' %]Fax
> [% CASE 'emailpro' %]Secondary email
> [% CASE 'phonepro' %]Secondary phone
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
>index 57e4d49..b46424e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
>@@ -34,12 +34,12 @@
> [% ELSE %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
> [% IF ( phonepro ) %]<li>Secondary phone: [% phonepro %]</li>[% END %]
>- [% IF ( mobile ) %]<li>Mobile phone: [% mobile %]</li>[% END %]
>+ [% IF ( mobile ) %]<li>Other phone: [% mobile %]</li>[% END %]
> [% END %]
> 
> [% IF ( P ) %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
>- [% IF ( mobile ) %]<li>Mobile phone: [% mobile %]</li>[% END %]
>+ [% IF ( mobile ) %]<li>Other phone: [% mobile %]</li>[% END %]
> [% END %]
> 	[% IF ( fax ) %]<li>Fax: [% fax %]</li>[% END %]
> [% UNLESS ( I ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 8ebd31f..3b89653 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -201,12 +201,12 @@ function validate1(date) {
> [% ELSE %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
> [% IF ( phonepro ) %]<li>Secondary phone: [% phonepro %]</li>[% END %]
>- [% IF ( mobile ) %]<li>Mobile phone: [% mobile %]</li>[% END %]
>+ [% IF ( mobile ) %]<li>Other phone: [% mobile %]</li>[% END %]
> [% END %]
> 
> [% IF ( P ) %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
>- [% IF ( mobile ) %]<li>Mobile phone: [% mobile %]</li>[% END %]
>+ [% IF ( mobile ) %]<li>Other phone: [% mobile %]</li>[% END %]
> [% END %] 	
> 	[% IF ( fax ) %]<li>Fax: [% fax %]</li>[% END %]
> [% UNLESS ( I ) %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index bbca649..5e2e747 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -396,7 +396,7 @@
> [% ELSE %]
> <label for="borrower_mobile">
> [% END %]
>- Mobile phone:</label>
>+ Other phone:</label>
> 
> <input type="text" id="borrower_mobile" name="borrower_mobile" value="[% borrower.mobile %]" />
> [% IF mandatory.defined('mobile') %]Required[% END %]
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 13142: 33520 | 34304 | 34305 | 35577 | 35615