Attachment 35622 Details for Bug 13418 – [PASSED QA] Bug 13418: [QA Follow-up] Use unshift instead of push

[patch] [PASSED QA] Bug 13418: [QA Follow-up] Use unshift instead of push

PASSED-QA-Bug-13418-QA-Follow-up-Use-unshift-inste.patch (text/plain), 1.04 KB, created by Kyle M Hall (khall) on 2015-01-30 13:21:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-01-30 13:21:57 UTC

Size: 1.04 KB

patch

obsolete

>From 4bf2eb942901600fc4c2c5068e62bcd91fb00e9a Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 19 Jan 2015 15:05:03 +0100
>Subject: [PATCH] [PASSED QA] Bug 13418: [QA Follow-up] Use unshift instead of push
>
>Some SQL parameters are added to the wrong side of the list.
>This effectively clears all private lists from view :)
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/VirtualShelves.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm
>index 24ee6dd..0ae9361 100644
>--- a/C4/VirtualShelves.pm
>+++ b/C4/VirtualShelves.pm
>@@ -111,7 +111,7 @@ sub GetShelves {
>             LEFT JOIN virtualshelfshares sh ON sh.shelfnumber=vs.shelfnumber
>             AND sh.borrowernumber=?
>         WHERE category=1 AND (vs.owner=? OR sh.borrowernumber=?) };
>-        push @params, ($owner) x 3;
>+        unshift @params, ($owner) x 3;
>     }
>     else {
>         $query.= 'WHERE category=2 ';
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13418: 34237 | 34238 | 35386 | 35387 | 35388 | 35438 | 35620 | 35621 | 35622 | 35623