Bugzilla – Attachment 35625 Details for
Bug 13244
GetCancelledOrders and GetOrders can be merged
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13244: Follow-up for unneeded redeclaration
PASSED-QA-Bug-13244-Follow-up-for-unneeded-redecla.patch (text/plain), 1.10 KB, created by
Kyle M Hall (khall)
on 2015-01-30 13:41:13 UTC
(
hide
)
Description:
[PASSED QA] Bug 13244: Follow-up for unneeded redeclaration
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-01-30 13:41:13 UTC
Size:
1.10 KB
patch
obsolete
>From adc985949f6e63a373784d26c0e781d847a8307d Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 28 Jan 2015 15:50:18 +0100 >Subject: [PATCH] [PASSED QA] Bug 13244: Follow-up for unneeded redeclaration > >Resolves: > FAIL acqui/basket.pl > OK critic > OK forbidden patterns > OK pod > FAIL valid > "my" variable @results masks earlier declaration in same scope > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > acqui/basket.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/acqui/basket.pl b/acqui/basket.pl >index 55770ea..6879a04 100755 >--- a/acqui/basket.pl >+++ b/acqui/basket.pl >@@ -365,7 +365,7 @@ if ( $op eq 'delete_confirm' ) { > push @book_foot_loop, map {$_} values %foot; > > # Get cancelled orders >- my @results = GetOrders($basketno, { cancelled => 1 }); >+ @results = GetOrders($basketno, { cancelled => 1 }); > my @cancelledorders_loop; > for my $order (@results) { > my $line = get_order_infos( $order, $bookseller); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13244
:
33517
|
33518
|
33519
|
35582
|
35583
|
35584
|
35585
|
35586
|
35624
|
35625
|
35626
|
36034
|
36035