Bugzilla – Attachment 35635 Details for
Bug 13339
Cart button doesn't open the cart
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 13339 - Cart button doesn't open the cart
Signed-off-Bug-13339---Cart-button-doesnt-open-the.patch (text/plain), 2.29 KB, created by
Marc Véron
on 2015-01-30 15:38:04 UTC
(
hide
)
Description:
[Signed-off] Bug 13339 - Cart button doesn't open the cart
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-01-30 15:38:04 UTC
Size:
2.29 KB
patch
obsolete
>From 0622571ec6f1335e8d50d1267438106ba6b99752 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 22 Jan 2015 14:25:29 -0500 >Subject: [PATCH] [Signed-off] Bug 13339 - Cart button doesn't open the cart >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The link to open the cart no longer triggers the cart popup. Instead, in >order to make it more usable with mobile devices, it triggers a menu >which displays the count of items in the cart -- something which >previously was done with a hover action (something touch-screen devices >don't have). Clicking/tapping this menu item is what opens the cart >window. > >Since the cart link is really now a menu trigger rather than just a >link, it seems logical to add the small arrow which the lists link >has indicating that the link triggers a menu. > >To test, apply the patch and view any page in a Cart-enabled OPAC. >Confirm that the "caret" icon displays correctly when the cart is both >empty and when it has contents. > >Followed test plan. Icon displays as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 94dec72..904c232 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -20,7 +20,7 @@ > [% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) %] > <li class="dropdown"> > <a href="#" class="dropdown-toggle" id="cartmenulink" data-toggle="dropdown" role="button"> >- <i id="carticon" class="icon-shopping-cart icon-white"></i> <span class="cartlabel">Cart</span> <span id="basketcount"></span> >+ <i id="carticon" class="icon-shopping-cart icon-white"></i> <span class="cartlabel">Cart</span> <span id="basketcount"></span> <b class="caret"></b> > </a> > <ul aria-labelledby="cartmenulink" role="menu" class="dropdown-menu"> > <li role="presentation"> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13339
:
35475
|
35635
|
35649