Bugzilla – Attachment 35676 Details for
Bug 13670
Patron holds table not loading when holds tab anchor is used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13670 - Patron holds table not loading when holds tab anchor is used
Bug-13670---Patron-holds-table-not-loading-when-ho.patch (text/plain), 1.72 KB, created by
Kyle M Hall (khall)
on 2015-02-05 17:48:22 UTC
(
hide
)
Description:
Bug 13670 - Patron holds table not loading when holds tab anchor is used
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-02-05 17:48:22 UTC
Size:
1.72 KB
patch
obsolete
>From 3710e58f7b41ce470f74806d23e0ad98d7d2719f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 5 Feb 2015 09:21:12 -0500 >Subject: [PATCH] Bug 13670 - Patron holds table not loading when holds tab anchor is used > >If a link to a patron record ends with #reserves, the holds tab is selected >on page load, but the holds table does not load. > >Test Plan: >1) Build your holds queue >2) From the holds queue report, open any patron link >3) Note the patron's reserves do not load >4) Apply this patch >5) Clear your browser cache >6) Repeat step 2 >7) Note the holds table now loads > >Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> >--- > koha-tmpl/intranet-tmpl/prog/en/js/holds.js | 13 +++++++++---- > 1 files changed, 9 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/holds.js b/koha-tmpl/intranet-tmpl/prog/en/js/holds.js >index 60f747b..f2cc350 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/holds.js >@@ -1,7 +1,13 @@ > $(document).ready(function() { >- // Don't load holds table unless it is clicked on > var holdsTable; >- $("#holds-tab").click( function() { >+ >+ // Don't load holds table unless it is clicked on >+ $("#holds-tab").on( "click", function(){ load_holds_table() } ); >+ >+ // If the holds tab is preselected on load, we need to load the table >+ if ( $("#holds-tab").parent().hasClass('ui-state-active') ) { load_holds_table() } >+ >+ function load_holds_table() { > if ( ! holdsTable ) { > holdsTable = $("#holds-table").dataTable({ > "bAutoWidth": false, >@@ -127,6 +133,5 @@ $(document).ready(function() { > }); > } > } >- }); >- >+ } > }); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13670
:
35670
|
35671
|
35676
|
35731