Attachment 35692 Details for Bug 7904 – Bug 7904: (QA followup) fix tests

[patch] Bug 7904: (QA followup) fix tests

Bug-7904-QA-followup-fix-tests.patch (text/plain), 1.58 KB, created by Tomás Cohen Arazi (tcohen) on 2015-02-05 18:52:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2015-02-05 18:52:55 UTC

Size: 1.58 KB

patch

obsolete

>From e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Thu, 5 Feb 2015 15:50:30 -0300
>Subject: [PATCH] Bug 7904: (QA followup) fix tests
>
>The package name for SIP wasn't fixed in the tests by the original patches.
>
>This patch fixes it.
>
>To test:
>- Run
>  $ prove t/db_dependent/SIP_ILS.t
>- Tests should pass with the patch.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>---
> t/db_dependent/SIP_ILS.t | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/SIP_ILS.t b/t/db_dependent/SIP_ILS.t
>index daf1c29..c9879dc 100755
>--- a/t/db_dependent/SIP_ILS.t
>+++ b/t/db_dependent/SIP_ILS.t
>@@ -9,19 +9,17 @@ use warnings;
> use Test::More tests => 4;
> 
> BEGIN {
>-        use FindBin;
>-        use lib "$FindBin::Bin/../../C4/SIP";
>         use_ok('C4::SIP::ILS');
> };
> 
>-my $transaction = ILS::Transaction::RenewAll->new();
>+my $transaction = C4::SIP::ILS::Transaction::RenewAll->new();
> 
>-$transaction->patron(my $patron = ILS::Patron->new(23529000120056));
>+$transaction->patron(my $patron = C4::SIP::ILS::Patron->new(23529000120056));
> 
> ok(defined $patron, "patron code: 23529000120056 is valid");
> 
>-my $transaction2 = ILS::Transaction::RenewAll->new();
>-$transaction2->patron(my $patron2 = ILS::Patron->new("ABCDE12345"));
>+my $transaction2 = C4::SIP::ILS::Transaction::RenewAll->new();
>+$transaction2->patron(my $patron2 = C4::SIP::ILS::Patron->new("ABCDE12345"));
> 
> #This test assumes that the patron code ABCDE12345 is invalid
> ok(!defined $patron2, "patron code: ABCDE12345 is invalid");
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 7904: 33057 | 33400 | 35447 | 35448 | 35449 | 35571 | 35572 | 35574 | 35692