Attachment 35706 Details for Bug 13240 – [PASSED QA] Bug 13240: Remove commented warns

[patch] [PASSED QA] Bug 13240: Remove commented warns

PASSED-QA-Bug-13240-Remove-commented-warns.patch (text/plain), 3.43 KB, created by Kyle M Hall (khall) on 2015-02-06 14:48:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-02-06 14:48:08 UTC

Size: 3.43 KB

patch

obsolete

>From 8a27e0cb47217c142881558bc3dfe341776cc48a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 12 Nov 2014 12:24:10 +0100
>Subject: [PATCH] [PASSED QA] Bug 13240: Remove commented warns
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> misc/cronjobs/advance_notices.pl |    6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
>diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl
>index edcaee7..9112935 100755
>--- a/misc/cronjobs/advance_notices.pl
>+++ b/misc/cronjobs/advance_notices.pl
>@@ -228,7 +228,6 @@ my @letters;
> UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
>     @letters = ();
>     warn 'examining ' . $upcoming->{'itemnumber'} . ' upcoming due items' if $verbose;
>-    # warn( Data::Dumper->Dump( [ $upcoming ], [ 'overdue' ] ) );
> 
>     my $from_address = $upcoming->{branchemail} || $admin_adress;
> 
>@@ -237,7 +236,6 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
>         # This item is due today. Send an 'item due' message.
>         $borrower_preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $upcoming->{'borrowernumber'},
>                                                                                    message_name   => 'item_due' } );
>-        # warn( Data::Dumper->Dump( [ $borrower_preferences ], [ 'borrower_preferences' ] ) );
>         next unless $borrower_preferences;
>         
>         if ( $borrower_preferences->{'wants_digest'} ) {
>@@ -271,7 +269,6 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
>     } else {
>         $borrower_preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $upcoming->{'borrowernumber'},
>                                                                                    message_name   => 'advance_notice' } );
>-        # warn( Data::Dumper->Dump( [ $borrower_preferences ], [ 'borrower_preferences' ] ) );
>         next UPCOMINGITEM unless $borrower_preferences && exists $borrower_preferences->{'days_in_advance'};
>         next UPCOMINGITEM unless $borrower_preferences->{'days_in_advance'} == $upcoming->{'days_until_due'};
> 
>@@ -325,7 +322,6 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
> }
> 
> 
>-# warn( Data::Dumper->Dump( [ $upcoming_digest ], [ 'upcoming_digest' ] ) );
> 
> # Now, run through all the people that want digests and send them
> 
>@@ -344,7 +340,6 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$upcoming_digest ) {
> 
>     my $borrower_preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrowernumber,
>                                                                                   message_name   => 'advance_notice' } );
>-    # warn( Data::Dumper->Dump( [ $borrower_preferences ], [ 'borrower_preferences' ] ) );
>     next PATRON unless $borrower_preferences; # how could this happen?
> 
> 
>@@ -404,7 +399,6 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$due_digest ) {
> 
>     my $borrower_preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrowernumber,
>                                                                                   message_name   => 'item_due' } );
>-    # warn( Data::Dumper->Dump( [ $borrower_preferences ], [ 'borrower_preferences' ] ) );
>     next PATRON unless $borrower_preferences; # how could this happen?
> 
>     my $letter_type = 'DUEDGST';
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13240: 33478 | 33479 | 35361 | 35362 | 35704 | 35705 | 35706 | 35707