Attachment 35717 Details for Bug 7736 – Bug 7904: (QA followup) fix tests

[patch] Bug 7904: (QA followup) fix tests

Bug-7904-QA-followup-fix-tests.patch (text/plain), 1.70 KB, created by Brendan Gallagher on 2015-02-07 17:28:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Gallagher

Created: 2015-02-07 17:28:02 UTC

Size: 1.70 KB

patch

obsolete

>From 06fb2b36a077d73ae8896e65a993f2a4dc2d3543 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Thu, 5 Feb 2015 15:50:30 -0300
>Subject: [PATCH] Bug 7904: (QA followup) fix tests
>
>The package name for SIP wasn't fixed in the tests by the original patches.
>
>This patch fixes it.
>
>To test:
>- Run
>  $ prove t/db_dependent/SIP_ILS.t
>- Tests should pass with the patch.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>
>http://bugs.koha-community.org/show_bug.cgi?id=7736
>---
> t/db_dependent/SIP_ILS.t |   10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/SIP_ILS.t b/t/db_dependent/SIP_ILS.t
>index daf1c29..c9879dc 100755
>--- a/t/db_dependent/SIP_ILS.t
>+++ b/t/db_dependent/SIP_ILS.t
>@@ -9,19 +9,17 @@ use warnings;
> use Test::More tests => 4;
> 
> BEGIN {
>-        use FindBin;
>-        use lib "$FindBin::Bin/../../C4/SIP";
>         use_ok('C4::SIP::ILS');
> };
> 
>-my $transaction = ILS::Transaction::RenewAll->new();
>+my $transaction = C4::SIP::ILS::Transaction::RenewAll->new();
> 
>-$transaction->patron(my $patron = ILS::Patron->new(23529000120056));
>+$transaction->patron(my $patron = C4::SIP::ILS::Patron->new(23529000120056));
> 
> ok(defined $patron, "patron code: 23529000120056 is valid");
> 
>-my $transaction2 = ILS::Transaction::RenewAll->new();
>-$transaction2->patron(my $patron2 = ILS::Patron->new("ABCDE12345"));
>+my $transaction2 = C4::SIP::ILS::Transaction::RenewAll->new();
>+$transaction2->patron(my $patron2 = C4::SIP::ILS::Patron->new("ABCDE12345"));
> 
> #This test assumes that the patron code ABCDE12345 is invalid
> ok(!defined $patron2, "patron code: ABCDE12345 is invalid");
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 7736: 8275 | 8276 | 8446 | 8635 | 10226 | 12398 | 12438 | 12467 | 13071 | 15304 | 15729 | 16538 | 16629 | 16649 | 16652 | 16667 | 16732 | 16761 | 16779 | 16792 | 16864 | 16865 | 16866 | 16867 | 16868 | 16869 | 16870 | 16871 | 16872 | 16873 | 16874 | 16882 | 16883 | 16884 | 16885 | 16886 | 17120 | 17121 | 20983 | 20984 | 21475 | 33953 | 33957 | 34332 | 34833 | 35030 | 35106 | 35716 | 35717 | 35718 | 36738 | 44079 | 44080 | 44081 | 44082 | 44083 | 44084 | 46996 | 47004 | 48623 | 48624 | 48625 | 48626 | 48971 | 48972 | 48973 | 48974 | 48975 | 48976 | 49037 | 49038 | 49039 | 49040 | 49041 | 49042 | 49307 | 49850 | 50002 | 50008