Bugzilla – Attachment 35732 Details for
Bug 13675
the budget of an order is set to null if not changed on receiving
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13675: Do not set aqorders.budget_id to NULL
PASSED-QA-Bug-13675-Do-not-set-aqordersbudgetid-to.patch (text/plain), 1.51 KB, created by
Katrin Fischer
on 2015-02-08 19:26:28 UTC
(
hide
)
Description:
[PASSED QA] Bug 13675: Do not set aqorders.budget_id to NULL
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-02-08 19:26:28 UTC
Size:
1.51 KB
patch
obsolete
>From b50c0d4203ccb9f16473ab91a785d15e257d78f1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 6 Feb 2015 16:19:14 +0100 >Subject: [PATCH] [PASSED QA] Bug 13675: Do not set aqorders.budget_id to NULL > >C4::Acquisition::ModReceiveOrder updates the aqorders with >budget_id=NULL if no budget_id given in parameter. >Actually the same budget_id should be used. >In tests (especially t/db_dependent/Acquisition/TransferOrder.t), >ModReceiveOrder is not called with a budget_id param and set to NULL the >budget_id value. > >test plan: > prove t/db_dependent/Acquisition/TransferOrder.t >should return green > >Note that this bug should not appear using the interface. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >The fix makes sense, and running > $ prove t/db_dependent/Acq* >returns all green. koha-qa.pl also likes it. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Acquisition.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index d59ae56..4eeac60 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1471,7 +1471,7 @@ q{SELECT * FROM aqorders WHERE biblionumber=? AND aqorders.ordernumber=?}, > $cost, > $rrp, > $ecost, >- $budget_id, >+ ( $budget_id ? $budget_id : $order->{budget_id} ), > ( defined $order_internalnote ? $order_internalnote : () ), > ( defined $order_vendornote ? $order_vendornote : () ), > $biblionumber, >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13675
:
35708
|
35710
| 35732