Bugzilla – Attachment 35802 Details for
Bug 7957
Routing lists: manage several routing list for each subscription, and export them as CSV
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7957: Remove uses of check_routing which doesn't exist anymore
Bug-7957-Remove-uses-of-checkrouting-which-doesnt-.patch (text/plain), 3.32 KB, created by
Julian Maurice
on 2015-02-10 15:39:24 UTC
(
hide
)
Description:
Bug 7957: Remove uses of check_routing which doesn't exist anymore
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2015-02-10 15:39:24 UTC
Size:
3.32 KB
patch
obsolete
>From cb087cd37109194a6adae3bbe1e6989582b8f517 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Tue, 10 Feb 2015 16:35:19 +0100 >Subject: [PATCH] Bug 7957: Remove uses of check_routing which doesn't exist > anymore > >Also remove a unit tests about C4::Serials::addroutingmember which >also no longer exists >--- > acqui/newordersubscription.pl | 3 ++- > serials/serials-collection.pl | 2 +- > serials/serials-recieve.pl | 3 ++- > t/db_dependent/Serials.t | 6 +----- > 4 files changed, 6 insertions(+), 8 deletions(-) > >diff --git a/acqui/newordersubscription.pl b/acqui/newordersubscription.pl >index cb04c64..a8f5393 100755 >--- a/acqui/newordersubscription.pl >+++ b/acqui/newordersubscription.pl >@@ -25,6 +25,7 @@ use C4::Branch; > use C4::Context; > use C4::Output; > use C4::Serials; >+use C4::Serials::RoutingLists qw( GetRoutingListsCount ); > > use Koha::Acquisition::Bookseller; > >@@ -72,7 +73,7 @@ foreach my $sub (@subscriptions) { > > # to toggle between create or edit routing list options > if ($routing) { >- $sub->{routingedit} = check_routing( $sub->{subscriptionid} ); >+ $sub->{routingedit} = GetRoutingListsCount( $sub->{subscriptionid} ); > } > } > >diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl >index e3f5ab3..ce03ff4 100755 >--- a/serials/serials-collection.pl >+++ b/serials/serials-collection.pl >@@ -129,7 +129,7 @@ if (@subscriptionid){ > my $numberpattern = C4::Serials::Numberpattern::GetSubscriptionNumberpattern($subs->{numberpattern}); > $subs->{frequency} = $frequency; > $subs->{numberpattern} = $numberpattern; >- $subs->{'hasRouting'} = check_routing($subscriptionid); >+ $subs->{'hasRouting'} = GetRoutingListsCount($subscriptionid); > push @$subscriptiondescs,$subs; > my $tmpsubscription= GetFullSubscription($subscriptionid); > @subscriptioninformation=(@$tmpsubscription,@subscriptioninformation); >diff --git a/serials/serials-recieve.pl b/serials/serials-recieve.pl >index 9fbce35..1c8aeaf 100755 >--- a/serials/serials-recieve.pl >+++ b/serials/serials-recieve.pl >@@ -73,6 +73,7 @@ use C4::Koha; > use C4::Output; > use C4::Context; > use C4::Serials; >+use C4::Serials::RoutingLists qw/GetRoutingListsCount/; > use C4::Branch; # GetBranches > > my $query = new CGI; >@@ -104,7 +105,7 @@ my $subscription=GetSubscription($subscriptionid); > > > my $auser = $subscription->{'librarian'}; # bob >-my $routing = check_routing($subscriptionid); # to see if routing list exists >+my $routing = GetRoutingListsCount($subscriptionid); # to see if routing list exists > my $manualdate =''; > my $manualissue =''; > my $manualstatus =0; >diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t >index c255b9e..1e44ef8 100644 >--- a/t/db_dependent/Serials.t >+++ b/t/db_dependent/Serials.t >@@ -15,7 +15,7 @@ use C4::Bookseller; > use C4::Biblio; > use C4::Budgets; > use Koha::DateUtils; >-use Test::More tests => 43; >+use Test::More tests => 41; > > BEGIN { > use_ok('C4::Serials'); >@@ -179,10 +179,6 @@ is(C4::Serials::updateClaim(),undef, 'test updating claim'); > > is(C4::Serials::getsupplierbyserialid(),undef, 'test getting supplier idea'); > >-is(C4::Serials::check_routing(), undef, 'test checking route'); >- >-is(C4::Serials::addroutingmember(),undef, 'test adding route member'); >- > > # Unit tests for statuses management (Bug 11689) > $subscriptionid = NewSubscription( >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7957
:
9259
|
10973
|
13217
|
16614
|
21340
|
22726
|
35709
|
35801
|
35802
|
35803
|
35804
|
35842
|
35860
|
35872
|
35873
|
35874
|
35875
|
38425
|
41762
|
41763
|
41764
|
42427
|
42428
|
42429
|
47633
|
47634
|
47635
|
47659
|
47660
|
47661
|
47662
|
47663
|
47664
|
50226
|
50227
|
50228
|
50265
|
50266
|
50270
|
50273
|
97519
|
97520
|
97521
|
97522
|
97523
|
97524