Attachment 35805 Details for Bug 13657 – Bug 13657 - Don't show extra comma after guarantor name on patron details

[patch] Bug 13657 - Don't show extra comma after guarantor name on patron details

ALTERNATIVE-PATCH-Bug-13657---Dont-show-extra-comm.patch (text/plain), 1.68 KB, created by Marc Véron on 2015-02-10 15:46:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2015-02-10 15:46:12 UTC

Size: 1.68 KB

patch

obsolete

>From 499ace98ff98419dc3020a84880cf51a38b91512 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Tue, 10 Feb 2015 16:37:41 +0100
>Subject: [PATCH] [ALTERNATIVE PATCH] Bug 13657 - Don't show extra comma after
> guarantor name on patron details
>
>This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations.
>
>To test:
>Apply this patch (without the first patch).
>Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 8ebd31f..ab1e96c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -228,7 +228,7 @@ function validate1(date) {
>         [% END %]
>     [% ELSE %]
>         [% IF ( guarantorborrowernumber ) %]
>-            <li><span class="label">Guarantor:</span><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% guarantorborrowernumber %]">[% guarantorsurname %], [% guarantorfirstname %]</a></li>
>+            <li><span class="label">Guarantor:</span><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% guarantorborrowernumber %]">[% guarantorsurname %][%IF ( guarantorfirstname ) %], [% guarantorfirstname %] [% END %]</a></li>
>         [% END %]
>     [% END %]
> </ol>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13657: 35775 | 35805 | 36266 | 36548