Attachment 35882 Details for Bug 13663 – Bug 13663: allow a librarian with circulate_remaining_permissions to upload koc files

[patch] Bug 13663: allow a librarian with circulate_remaining_permissions to upload koc files

Bug-13663-allow-a-librarian-with-circulateremainin.patch (text/plain), 1.35 KB, created by Brendan Gallagher on 2015-02-12 23:34:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Gallagher

Created: 2015-02-12 23:34:22 UTC

Size: 1.35 KB

patch

obsolete

>From 1851c56e40c110935418442d02b3a8eae5be910f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 3 Feb 2015 15:55:48 +0100
>Subject: [PATCH] Bug 13663: allow a librarian with
> circulate_remaining_permissions to upload koc files
>
>The tools/upload-file.pl script require one of the tools permissions to
>upload koc files.
>This script is called by offline_circ/process_koc.pl which requires circulate_remaining_permissions.
>
>It does not make sense to require another permission for this script.
>
>Test plan:
>Verify that the circulate_remaining_permissions perm is enough to upload
>.koc file.
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>---
> tools/upload-file.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/upload-file.pl b/tools/upload-file.pl
>index dd8c4f5..9b8c9d2 100755
>--- a/tools/upload-file.pl
>+++ b/tools/upload-file.pl
>@@ -39,7 +39,7 @@ use C4::UploadedFile;
> # have been created.
> 
> my %cookies = fetch CGI::Cookie;
>-my ($auth_status, $sessionID) = check_cookie_auth($cookies{'CGISESSID'}->value, { tools => '*' });
>+my ($auth_status, $sessionID) = check_cookie_auth($cookies{'CGISESSID'}->value, { circulate => "circulate_remaining_permissions" });
> if ($auth_status ne "ok") {
>     $auth_status = 'denied' if $auth_status eq 'failed';
>     send_reply($auth_status, "");
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13663: 35661 | 35882 | 40089 | 40123 | 40124 | 41380 | 41381