Attachment 35906 Details for Bug 13709 – Bug 13709 - Patron cards creator utf-8 encoding and ttf fonts broken

[patch] Bug 13709 - Patron cards creator utf-8 encoding and ttf fonts broken

Bug-13709---Patron-cards-creator-utf-8-encoding-an.patch (text/plain), 1.98 KB, created by Dobrica Pavlinusic on 2015-02-13 14:42:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dobrica Pavlinusic

Created: 2015-02-13 14:42:17 UTC

Size: 1.98 KB

patch

obsolete

>From 970bc388925b067dc3813c70acfafef848bc10ab Mon Sep 17 00:00:00 2001
>From: Dobrica Pavlinusic <dpavlin@rot13.org>
>Date: Fri, 13 Feb 2015 15:37:12 +0100
>Subject: [PATCH] Bug 13709 - Patron cards creator utf-8 encoding and ttf fonts broken
>
>This change is similar to Bug 8375 which introduced ttf fonts for
>labels printing in order to support diacritics and utf-8 encoding,
>but this change was never implemented for patron cards.
>
>Test scenario:
>
>1. make sure that you have <ttf> font mapping in koha-conf.xml
>2. define partron card layout, template, profile and batch
>   (with utf-8 chars, probably in patron firstname or surname)
>3. verify that without this patch pdf export file is error message
>   Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820
>4. apply this patch and verify that generated pdf has correct encoding
>---
> C4/Patroncards/Patroncard.pm |    9 +++------
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/C4/Patroncards/Patroncard.pm b/C4/Patroncards/Patroncard.pm
>index 339b969..f130a04 100644
>--- a/C4/Patroncards/Patroncard.pm
>+++ b/C4/Patroncards/Patroncard.pm
>@@ -173,13 +173,10 @@ sub draw_text {
>             }
>             box ($origin_llx, $box_lly, $self->{'width'} - $text_attribs->{'llx'}, $box_height, $pdf);
>         }
>-#        my $font_resource = $pdf->TTFont("/usr/share/fonts/truetype/msttcorefonts/Times_New_Roman_Bold.ttf");
>-#        $pdf->FontSize($text_attribs->{'font_size'});
>-        my $font_resource = $pdf->Font($text_attribs->{'font'});
>+        $pdf->Font($text_attribs->{'font'});
>+        $pdf->FontSize($text_attribs->{'font_size'});
>         foreach my $line (@lines) {
>-#            $pdf->Text($line->{'Tx'}, $line->{'Ty'}, $line->{'line'});
>-            my $text_line = "BT /$font_resource $text_attribs->{'font_size'} Tf $line->{'Tx'} $line->{'Ty'} Td $line->{'Tw'} Tw ($line->{'line'}) Tj ET";
>-            $pdf->Add($text_line);
>+            $pdf->Text($line->{'Tx'}, $line->{'Ty'}, $line->{'line'});
>         }
>     }
> }
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13709: 35906 | 36264 | 36558