Attachment 36049 Details for Bug 12847 – [SIGNED OFF] Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::GetPendingIssues already creates it

[patch] [SIGNED OFF] Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::GetPendingIssues already creates it

SIGNED-OFF-Bug-12847-Follwup---Remove-code-that-ca.patch (text/plain), 1.61 KB, created by Nick Clemens (kidclamp) on 2015-02-19 19:15:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2015-02-19 19:15:11 UTC

Size: 1.61 KB

patch

obsolete

>From 641002889d21dc1c606076ab031b0f9cc8fd00cc Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 29 Aug 2014 09:46:16 -0400
>Subject: [PATCH] [SIGNED OFF] Bug 12847 [Follwup] - Remove code that
> calculates "overdue" key as C4::Members::GetPendingIssues
> already creates it
>
>Signed-off-by: Laurie McKee <lmckee@littleelm.org>
>Signed-off-by: Nick <Nick@quechelibrary.org>
>---
> C4/Members.pm |    7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/C4/Members.pm b/C4/Members.pm
>index dd30b67..3f36c14 100644
>--- a/C4/Members.pm
>+++ b/C4/Members.pm
>@@ -2444,15 +2444,10 @@ sub IssueSlip {
>         $dt_issuedate->truncate( to => 'day' );
>         my $dt_lastreneweddate = dt_from_string( $it->{'lastreneweddate'} );
>         $dt_lastreneweddate->truncate( to => 'day' );
>-        my $dt_date_due = dt_from_string( $it->{'date_due'} );
>-        $dt_date_due->truncate( to => 'day' );
> 
>         if ( $dt_issuedate == $now || $dt_lastreneweddate == $now ) {
>             $it->{'now'} = 1;
>         }
>-        elsif ( $dt_date_due < $now ) {
>-            $it->{'overdue'} = 1;
>-        }
> 
>         # Recreate date_due as DateTime because we truncated the hours
>         $it->{'date_due'} = output_pref( dt_from_string( $it->{'date_due'} ) );
>@@ -2477,7 +2472,7 @@ sub IssueSlip {
>                 'biblio' => $_,
>                 'items'  => $_,
>                 'issues' => $_,
>-            }, grep { !$_->{'overdue'} } @issues ],
>+            }, grep { !$_->{'overdue'} } @issues ], # overdue key created by GetPendingIssues
> 
>             'overdue' => [ map {
>                 'biblio' => $_,
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 12847: 31280 | 31281 | 31286 | 35969 | 36048 | 36049 | 37908 | 37946 | 37992 | 38020 | 38302