Attachment 36072 Details for Bug 12858 – [PASSED QA] Bug 12858: Add error handling to Syndetics Index

[patch] [PASSED QA] Bug 12858: Add error handling to Syndetics Index

PASSED-QA-Bug-12858-Add-error-handling-to-Syndetic.patch (text/plain), 1.59 KB, created by Kyle M Hall (khall) on 2015-02-20 12:25:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-02-20 12:25:56 UTC

Size: 1.59 KB

patch

obsolete

>From 5ad640e87ccf2306797a42c50ff6873b828893da Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 2 Sep 2014 09:14:03 +0000
>Subject: [PATCH] [PASSED QA] Bug 12858: Add error handling to Syndetics Index
>
>* Syndetics routines include a statement to check that the returned
>  content from Syndetics is xml. The get_syndetics_index routine was
>  missing this check and so when a 'not found' html page was returned
>  the opac-detail page would take a long time to load whilst xml::simple
>  attempted to parse the large html document.
>
>  Test Plan
>  1. Enable Syndetics indexes on opac.
>  2. Head over to an opac-detail page on the opac.
>  3. Remove the ISBN from the same item in the staff client.
>  4. Reload the opac-detail page for the item noticeing a much slower
>  page load.
>  5. Apply the patch
>  6. Reload the opac-detail page for the item and note that it now laods
>  in a reasonable timescale again.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/External/Syndetics.pm |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/C4/External/Syndetics.pm b/C4/External/Syndetics.pm
>index 3d518da..2d14674 100644
>--- a/C4/External/Syndetics.pm
>+++ b/C4/External/Syndetics.pm
>@@ -66,6 +66,9 @@ sub get_syndetics_index {
>     my ( $isbn,$upc,$oclc ) = @_;
> 
>     my $response = _fetch_syndetics_content('INDEX.XML', $isbn, $upc, $oclc);
>+    unless ($response->content_type =~ /xml/) {
>+        return;
>+    }
> 
>     my $content = $response->content;
>     my $xmlsimple = XML::Simple->new();
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 12858: 31318 | 36010 | 36072 | 36073 | 36074