Bugzilla – Attachment 3615 Details for
Bug 5860
Adding duplicate stocknumber will fail silently
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed patch
patch.txt (text/plain), 2.30 KB, created by
Marcel de Rooy
on 2011-04-04 11:21:33 UTC
(
hide
)
Description:
Signed patch
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2011-04-04 11:21:33 UTC
Size:
2.30 KB
patch
obsolete
>From ced6fdffd6ab1f14bba005639b83a0e5abc10957 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Tue, 29 Mar 2011 22:50:15 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 5860: Adding duplicate stocknumber fails silently >Content-Type: text/plain; charset="utf-8" > >When adding a duplicate stocknumber the duplicate was not saved to the database. >This happened, because the field stocknumber in table items was declared to be unique. >Discussion on bug suggests to lift this restriction. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Tested. Corrected typo in updatedatabase script. Version 3.01.00.095 introduced the index with double s, although structure had only one s in index name. >Unaware of this bug, I entered the more general bug 6041 for similar problems with modifying items. >--- > installer/data/mysql/kohastructure.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 8 ++++++++ > 2 files changed, 9 insertions(+), 1 deletions(-) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index e0bea81..7a41617 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1023,7 +1023,7 @@ CREATE TABLE `items` ( > `stocknumber` varchar(32) default NULL, > PRIMARY KEY (`itemnumber`), > UNIQUE KEY `itembarcodeidx` (`barcode`), >- UNIQUE KEY `itemstocknumberidx` (`stocknumber`), >+ KEY `itemstocknumberidx` (`stocknumber`), > KEY `itembinoidx` (`biblioitemnumber`), > KEY `itembibnoidx` (`biblionumber`), > KEY `homebranch` (`homebranch`), >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 5c71849..f60e6df 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -4209,6 +4209,14 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) { > SetVersion ($DBversion); > } > >+$DBversion = '3.03.00.XXX'; >+if (C4::Context->preference("Version") < TransformToNum($DBversion)) { >+ $dbh->do("ALTER TABLE `items` DROP INDEX `itemsstocknumberidx`;"); >+ $dbh->do("ALTER TABLE items ADD INDEX itemstocknumberidx (stocknumber);"); >+ print "Upgrade to $DBversion done (Change items.stocknumber to be not unique)\n"; >+ SetVersion ($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 DropAllForeignKeys($table) >-- >1.6.0.6 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5860
:
3506
|
3615
|
4092
|
4103
|
4121
|
4122
|
4123
|
4141
|
4143
|
4144