Bugzilla – Attachment 3628 Details for
Bug 6046
Managed by list in suggestions was not created correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch
0001-Bug-6046-suggestedby-list-on-she-filter-was-not-crea.patch (text/plain), 1.20 KB, created by
Paul Poulain
on 2011-04-04 13:46:04 UTC
(
hide
)
Description:
proposed patch
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2011-04-04 13:46:04 UTC
Size:
1.20 KB
patch
obsolete
>From 48f68920290f473821b51c11add8f581cfd724b4 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Mon, 4 Apr 2011 15:45:40 +0200 >Subject: [PATCH] Bug 6046: suggestedby list on she filter was not created properly > >The suggestedby patron list contained empty lines. This was because retrieving patron name was not correct >--- > suggestion/suggestion.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index cb8c5f9..2b4e3d9 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -56,7 +56,7 @@ sub GetCriteriumDesc{ > return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc( $criteriumvalue))) if ($displayby =~/status/i); > return (GetBranchName($criteriumvalue)) if ($displayby =~/branchcode/); > return (GetSupportName($criteriumvalue)) if ($displayby =~/itemtype/); >- if ($displayby =~/managedby/||$displayby =~/acceptedby/){ >+ if ($displayby =~/suggestedby/||$displayby =~/managedby/||$displayby =~/acceptedby/){ > my $borr=C4::Members::GetMember(borrowernumber=>$criteriumvalue); > return "" unless $borr; > return $$borr{firstname} . ", " . $$borr{surname}; >-- >1.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6046
:
3628
|
3629