Bugzilla – Attachment 36428 Details for
Bug 13411
Koha's SIP server returns not ok for checking in items that are not checked out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13411 [QA Followup] - Add logging
Bug-13411-QA-Followup---Add-logging.patch (text/plain), 1.41 KB, created by
Benjamin Rokseth
on 2015-03-03 17:15:57 UTC
(
hide
)
Description:
Bug 13411 [QA Followup] - Add logging
Filename:
MIME Type:
Creator:
Benjamin Rokseth
Created:
2015-03-03 17:15:57 UTC
Size:
1.41 KB
patch
obsolete
>From 2a42360ed7d9994fa282fe3bc0ee9911aa8a19cd Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 2 Mar 2015 06:06:58 -0800 >Subject: [PATCH] Bug 13411 [QA Followup] - Add logging > >Added a fix for bug in C4/SIP/ILS.pm line 202 as described above. > >Tested OK. Setting to Signed Off as it works as previously noted. >--- > C4/SIP/ILS.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 8bc95bc..a50de25 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -191,13 +191,15 @@ sub checkin { > # It's ok to check it in if it exists, and if it was checked out > # or it was not checked out but the checked_in_ok flag was set > $circ->ok( ( $checked_in_ok && $item ) || ( $item && $item->{patron} ) ); >+ syslog("LOG_DEBUG", "C4::SIP::ILS::checkin - using checked_in_ok") if $checked_in_ok; > > if ( !defined( $item->{patron} ) ) { > $circ->screen_msg("Item not checked out") unless $checked_in_ok; >+ syslog("LOG_DEBUG", "C4::SIP::ILS::checkin - item not checked out"); > } > else { > if ( $circ->ok ) { >- $circ->patron( $patron = new ILS::Patron $item->{patron} ); >+ $circ->patron($patron = C4::SIP::ILS::Patron->new( $item->{patron} )); > delete $item->{patron}; > delete $item->{due_date}; > $patron->{items} = [ grep { $_ ne $item_id } @{ $patron->{items} } ]; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13411
:
34187
|
35665
|
35667
|
35669
|
36271
|
36310
|
36428
|
40952
|
40953
|
42035
|
42036
|
42081
|
42082
|
43590
|
43591
|
45027
|
45028