Bugzilla – Attachment 36451 Details for
Bug 7677
Subscriptions: Ability to define default itemtype and automatically change itemtype of older issues on receive of next issue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7677: FIX QA issues
Bug-7677-FIX-QA-issues.patch (text/plain), 950 bytes, created by
Matthias Meusburger
on 2015-03-04 10:59:51 UTC
(
hide
)
Description:
Bug 7677: FIX QA issues
Filename:
MIME Type:
Creator:
Matthias Meusburger
Created:
2015-03-04 10:59:51 UTC
Size:
950 bytes
patch
obsolete
>From a61dc989c4e89734b824d5c8f9992696c0d449be Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 10 Mar 2014 11:58:33 +0100 >Subject: [PATCH] Bug 7677: FIX QA issues > > FAIL C4/Serials.pm > FAIL forbidden patterns > forbidden pattern: trailing space char (line 1501) > forbidden pattern: trailing space char (line 921) > > FAIL serials/serials-edit.pl > FAIL valid > "my" variable $dbh masks earlier declaration in same scope >--- > serials/serials-edit.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl >index 6a5d7dc..8d5d4bc 100755 >--- a/serials/serials-edit.pl >+++ b/serials/serials-edit.pl >@@ -91,7 +91,6 @@ if ( scalar(@subscriptionids) == 1 && index( $subscriptionids[0], q|,| ) > 0 ) { > } > my @errors; > my @errseq; >-my $dbh = C4::Context->dbh; > > # If user comes from subscription details > unless (@serialids) { >-- >1.7.10.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=36451">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7677
:
16339
|
16425
|
16456
|
20537
|
20538
|
24099
|
24635
|
25980
|
25981
|
25983
|
27774
|
28950
|
28951
|
28952
|
28953
|
29570
|
29571
|
29572
|
34220
|
34221
|
34222
|
34223
|
34665
|
36389
|
36446
|
36448
|
36449
|
36450
|
36451
|
36452
|
36453
|
36679
|
36680
|
36681
|
36682
|
36683
|
42923
|
42924
|
45938
|
45939
|
45940
|
45941
|
45942
|
45943
|
46216
|
47475
|
52010
|
54876
|
55000
|
55323
|
55466
|
55467
|
55468
|
55469
|
55470
|
55471
|
55472
|
55473
|
55474
|
55475