Attachment 36548 Details for Bug 13657 – [PASSED QA] Bug 13657 - Don't show extra comma after guarantor name on patron details

[patch] [PASSED QA] Bug 13657 - Don't show extra comma after guarantor name on patron details

PASSED-QA-Bug-13657---Dont-show-extra-comma-after-.patch (text/plain), 1.78 KB, created by Katrin Fischer on 2015-03-05 10:21:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-03-05 10:21:48 UTC

Size: 1.78 KB

patch

obsolete

>From 7788846e187ef6487b6d67d6930ff24461ca5096 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Tue, 10 Feb 2015 16:37:41 +0100
>Subject: [PATCH] [PASSED QA] Bug 13657 - Don't show extra comma after
> guarantor name on patron details
>
>This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations.
>
>To test:
>Apply this patch (without the first patch).
>Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page.
>
>Signed-off-by: Jesse Maseto <Jesse@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 3b89653..d01573b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -228,7 +228,7 @@ function validate1(date) {
>         [% END %]
>     [% ELSE %]
>         [% IF ( guarantorborrowernumber ) %]
>-            <li><span class="label">Guarantor:</span><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% guarantorborrowernumber %]">[% guarantorsurname %], [% guarantorfirstname %]</a></li>
>+            <li><span class="label">Guarantor:</span><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% guarantorborrowernumber %]">[% guarantorsurname %][%IF ( guarantorfirstname ) %], [% guarantorfirstname %] [% END %]</a></li>
>         [% END %]
>     [% END %]
> </ol>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13657: 35775 | 35805 | 36266 | 36548