Bugzilla – Attachment 36569 Details for
Bug 12291
Replace the acronym HTML tag with abbr
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC
Bug-12291-SIGNED-OFF-Replace-acronym-with-tag-at-t.patch (text/plain), 3.21 KB, created by
Magnus Enger
on 2015-03-05 11:37:14 UTC
(
hide
)
Description:
Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2015-03-05 11:37:14 UTC
Size:
3.21 KB
patch
obsolete
>From f31ea322c6ee1592c835b8ee264b7c063f47103b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 20 Feb 2015 11:42:31 +0100 >Subject: [PATCH] Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC > >On the OPAC authentification page, the acronym tag is used, but >deprecated. >It should be replaced with abbr: >http://www.w3.org/wiki/HTML/Elements/acronym > >Test plan: >Enable the CAS authentification and verify the tags have correctly been >replaced. > >Signed-off-by: Magnus Enger <magnus@enger.priv.no> >Befor the patch, "grep -r "<acronym" koha-tmpl/*/*/en/*" shows 4 occurences of ><acronym>, 3 related to CAS. After the patch, the same grep shows 1 remaining ><acronym>, in acqui/parcels.tt. I sign off this patch and will provide a >followup for the last occurrence. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >index a82b079..9ce6ff7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >@@ -69,7 +69,7 @@ > <!-- This is what is displayed if cas login has failed --> > <p>Sorry, the CAS login also failed, if you have a local login you may use that below.</p> > [% ELSE %] >- If you have a <acronym title="Central Authentication Service">CAS</acronym> account, you may use that below. >+ If you have a <abbr title="Central Authentication Service">CAS</abbr> account, you may use that below. > [% END %] > [% ELSE %] > If you have a local account, you may use that below. >@@ -84,7 +84,7 @@ > [% END %] > [% IF ( casAuthentication ) %] > <h4>CAS login</h4> >- <p>If you do not have a Shibboleth account, but you do have a <acronym title="Central Authentication Service">CAS</acronym> account, >+ <p>If you do not have a Shibboleth account, but you do have a <abbr title="Central Authentication Service">CAS</abbr> account, > [% ELSE %] > <h4>Local login</h4> > <p>If you do not have a Shibboleth account, but you do have a local login, then you may login below:</p> >@@ -114,7 +114,7 @@ > <p>Sorry, the CAS login failed.</p> > [% END %] > >- <p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account, >+ <p>If you have a <abbr title="Central Authentication Service">CAS</abbr> account, > [% IF ( casServerUrl ) %] > please <a href="[% casServerUrl %]">click here to login</a>.<p> > [% END %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12291
:
28347
|
28348
|
36064
|
36569
|
36572
|
36574
|
36580
|
36581