Attachment 36570 Details for Bug 12344 – QA followup: skip message type if template is missing

[patch] QA followup: skip message type if template is missing

QA-followup.patch (text/plain), 1.27 KB, created by Benjamin Rokseth on 2015-03-05 11:37:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Rokseth

Created: 2015-03-05 11:37:15 UTC

Size: 1.27 KB

patch

obsolete

>From 5651e9b0f8e256e5ebee5e07205e5d2763aa4cf2 Mon Sep 17 00:00:00 2001
>From: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
>Date: Thu, 5 Mar 2015 12:18:09 +0100
>Subject: [PATCH] QA followup:
>
>Use next instead of return when generating templates.
>In case patron has enabled a message type that misses a template,
>next message type will be attempted instead of returning at once.
>
>http://bugs.koha-community.org/show_bug.cgi?id=12344
>---
> C4/Circulation.pm |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 9f7a93f..9cae590 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3273,7 +3273,7 @@ sub SendCirculationAlert {
>                     'borrowers'   => $borrower,
>                     'branches'    => $branch,
>                 }
>-            ) or return;
>+            ) or next;
>             C4::Message->enqueue($letter, $borrower, $_);
>         } else {
>             #warn "append to old message";
>@@ -3290,7 +3290,7 @@ sub SendCirculationAlert {
>                     'borrowers'   => $borrower,
>                     'branches'    => $branch,
>                 }
>-            ) or return;
>+            ) or next;
>             $message->append($letter);
>             $message->update;
>         }
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 12344: 28605 | 28606 | 36406 | 36568 | 36570 | 36576 | 36577