Attachment 36588 Details for Bug 11998 – Bug 11998: QA follow-up - fix the perlcritic error

[patch] Bug 11998: QA follow-up - fix the perlcritic error

Bug-11998-QA-follow-up---fix-the-perlcritic-error.patch (text/plain), 1.05 KB, created by Brendan Gallagher on 2015-03-05 13:37:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Gallagher

Created: 2015-03-05 13:37:20 UTC

Size: 1.05 KB

patch

obsolete

>From 7769254190bd7e026f5c69f95384bfa54995a85f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 4 Nov 2014 09:06:24 +0100
>Subject: [PATCH] Bug 11998: QA follow-up - fix the perlcritic error
>
>% perlcritic C4/Context.pm
>Variable declared in conditional statement at line 544, column 5.
>Declare variables outside of the condition.  (Severity: 5)
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>---
> C4/Context.pm |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Context.pm b/C4/Context.pm
>index 2a67ed5..0f83467 100644
>--- a/C4/Context.pm
>+++ b/C4/Context.pm
>@@ -542,7 +542,8 @@ sub preference {
>     my $self = shift;
>     my $var  = shift;    # The system preference to return
> 
>-    my $cached_var = $syspref_cache->get_from_cache("syspref_$var") if $use_syspref_cache;
>+    my $cached_var;
>+    $cached_var = $syspref_cache->get_from_cache("syspref_$var") if $use_syspref_cache;
>     return $cached_var if defined $cached_var;
> 
>     my $dbh  = C4::Context->dbh or return 0;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11998: 26575 | 26621 | 26714 | 26716 | 26717 | 27382 | 31801 | 31802 | 32870 | 32871 | 32872 | 32873 | 32874 | 33183 | 33447 | 33670 | 33671 | 33685 | 33724 | 33725 | 33746 | 33829 | 33940 | 36523 | 36524 | 36525 | 36526 | 36527 | 36528 | 36529 | 36530 | 36531 | 36532 | 36533 | 36534 | 36571 | 36583 | 36584 | 36585 | 36586 | 36587 | 36588 | 36589 | 36590 | 36591 | 36592 | 36593 | 36594 | 36595 | 48640 | 48652 | 48655 | 48687 | 48688 | 48727 | 48758 | 48928 | 48929 | 48930 | 48931 | 48932 | 48933 | 48934 | 48935 | 48936 | 48961 | 49022 | 49023 | 49024 | 49025 | 49026 | 49027 | 49028 | 49029 | 49030 | 49100 | 49101 | 49102 | 49103 | 49104 | 49105 | 49106 | 49107 | 49108