Attachment 36590 Details for Bug 11998 – Bug 11998 - remove logging from places where it shouldn't be

[patch] Bug 11998 - remove logging from places where it shouldn't be

Bug-11998---remove-logging-from-places-where-it-sh.patch (text/plain), 2.12 KB, created by Brendan Gallagher on 2015-03-05 13:37:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Gallagher

Created: 2015-03-05 13:37:35 UTC

Size: 2.12 KB

patch

obsolete

>From d98230119774f8f2791dbef38b8c0e6df84723e2 Mon Sep 17 00:00:00 2001
>From: Robin Sheat <robin@catalyst.net.nz>
>Date: Wed, 19 Nov 2014 17:06:57 +1300
>Subject: [PATCH] Bug 11998 - remove logging from places where it shouldn't be
>
>This prevents duplicate action_log entries when a preference is updated.
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>---
> admin/preferences.pl         |    1 -
> misc/admin/koha-preferences  |    1 -
> svc/config/systempreferences |    2 --
> 3 files changed, 4 deletions(-)
>
>diff --git a/admin/preferences.pl b/admin/preferences.pl
>index a6b4776..be64be1 100755
>--- a/admin/preferences.pl
>+++ b/admin/preferences.pl
>@@ -305,7 +305,6 @@ if ( $op eq 'save' ) {
>             my $value = join( ',', $input->param( $param ) );
> 
>             C4::Context->set_preference( $pref, $value );
>-            logaction( 'SYSTEMPREFERENCE', 'MODIFY', undef, $pref . " | " . $value );
>         }
>     }
> 
>diff --git a/misc/admin/koha-preferences b/misc/admin/koha-preferences
>index 6728609..d8317ab 100755
>--- a/misc/admin/koha-preferences
>+++ b/misc/admin/koha-preferences
>@@ -82,7 +82,6 @@ sub _set_preference {
>     _debug( "Setting $preference to $value" );
> 
>     C4::Context->set_preference( $preference, $value );
>-    logaction( 'SYSTEMPREFERENCE', 'MODIFY', undef, $preference . " | " . $value );
> }
> 
> sub GetPreferences {
>diff --git a/svc/config/systempreferences b/svc/config/systempreferences
>index deeca51..e0322ba 100755
>--- a/svc/config/systempreferences
>+++ b/svc/config/systempreferences
>@@ -64,7 +64,6 @@ sub set_preference {
>     unless ( C4::Context->config('demo') ) {
>         my $value = join( ',', $query->param( 'value' ) );
>         C4::Context->set_preference( $preference, $value );
>-        logaction( 'SYSTEMPREFERENCE', 'MODIFY', undef, $preference . " | " . $value );
>     }
> 
>     C4::Service->return_success( $response );
>@@ -98,7 +97,6 @@ sub set_preferences {
>             my $value = join( ',', $query->param( $param ) );
> 
>             C4::Context->set_preference( $pref, $value );
>-            logaction( 'SYSTEMPREFERENCE', 'MODIFY', undef, $pref . " | " . $value );
>         }
>     }
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11998: 26575 | 26621 | 26714 | 26716 | 26717 | 27382 | 31801 | 31802 | 32870 | 32871 | 32872 | 32873 | 32874 | 33183 | 33447 | 33670 | 33671 | 33685 | 33724 | 33725 | 33746 | 33829 | 33940 | 36523 | 36524 | 36525 | 36526 | 36527 | 36528 | 36529 | 36530 | 36531 | 36532 | 36533 | 36534 | 36571 | 36583 | 36584 | 36585 | 36586 | 36587 | 36588 | 36589 | 36590 | 36591 | 36592 | 36593 | 36594 | 36595 | 48640 | 48652 | 48655 | 48687 | 48688 | 48727 | 48758 | 48928 | 48929 | 48930 | 48931 | 48932 | 48933 | 48934 | 48935 | 48936 | 48961 | 49022 | 49023 | 49024 | 49025 | 49026 | 49027 | 49028 | 49029 | 49030 | 49100 | 49101 | 49102 | 49103 | 49104 | 49105 | 49106 | 49107 | 49108