Attachment 36637 Details for Bug 13794 – Bug 13794 - New patch, the old patches were likely to cause regression issues.

[patch] Bug 13794 - New patch, the old patches were likely to cause regression issues.

Bug-13794---New-patch-the-old-patches-were-likely-.patch (text/plain), 1.24 KB, created by Maxime Beaulieu on 2015-03-05 22:02:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Maxime Beaulieu

Created: 2015-03-05 22:02:05 UTC

Size: 1.24 KB

patch

obsolete

>From 22d69be8dff5c90461eed65988c87f11a3238662 Mon Sep 17 00:00:00 2001
>From: mxbeaulieu <maxime.beaulieu@inlibro.com>
>Date: Thu, 5 Mar 2015 16:56:26 -0500
>Subject: [PATCH] Bug 13794 - New patch, the old patches were likely to cause
> regression issues.
>
>I left the code logic intact, and simply removed "text" from the regex.
>Text input field values are now translated, no other logical changes are introduced.
>---
> misc/translator/tmpl_process3.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/translator/tmpl_process3.pl b/misc/translator/tmpl_process3.pl
>index cb671ae..4ded16f 100755
>--- a/misc/translator/tmpl_process3.pl
>+++ b/misc/translator/tmpl_process3.pl
>@@ -64,7 +64,7 @@ sub text_replace_tag ($$) {
>     if ($attr->{$a}) {
>         next if $a eq 'label' && $tag ne 'optgroup';
>         next if $a eq 'content' && $tag ne 'meta';
>-        next if $a eq 'value' && ($tag ne 'input' || (ref $attr->{'type'} && $attr->{'type'}->[1] =~ /^(?:checkbox|hidden|radio|text)$/)); # FIXME
>+        next if $a eq 'value' && ($tag ne 'input' || (ref $attr->{'type'} && $attr->{'type'}->[1] =~ /^(?:checkbox|hidden|radio)$/)); # FIXME
> 
>         my($key, $val, $val_orig, $order) = @{$attr->{$a}}; #FIXME
>         if ($val =~ /\S/s) {
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 13794: 36514 | 36635 | 36637 | 36767 | 36816