Attachment 36671 Details for Bug 13507 – [PASSED QA] Bug 13507 [Follow-up] : Add unit test.

[patch] [PASSED QA] Bug 13507 [Follow-up] : Add unit test.

PASSED-QA-Bug-13507-Follow-up--Add-unit-test.patch (text/plain), 1.74 KB, created by Katrin Fischer on 2015-03-06 10:38:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-03-06 10:38:45 UTC

Size: 1.74 KB

patch

obsolete

>From 18c5e5607625d116e622d542548b0db77c4a08ef Mon Sep 17 00:00:00 2001
>From: Matthias Meusburger <matthias.meusburger@biblibre.com>
>Date: Fri, 2 Jan 2015 16:47:40 +0100
>Subject: [PATCH] [PASSED QA] Bug 13507 [Follow-up] : Add unit test.
>
>Signed-off-by: Koha Team AMU <koha.aixmarseille@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/db_dependent/Auth_with_cas.t | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Auth_with_cas.t b/t/db_dependent/Auth_with_cas.t
>index 8e0f783..eb359a9 100755
>--- a/t/db_dependent/Auth_with_cas.t
>+++ b/t/db_dependent/Auth_with_cas.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 3;
>+use Test::More tests => 4;
> use CGI;
> 
> use C4::Context;
>@@ -39,8 +39,10 @@ $dbh->{ AutoCommit } = 0;
> $dbh->{ RaiseError } = 1;
> 
> C4::Context->set_preference('OPACBaseURL','localhost');
>+C4::Context->set_preference('staffClientBaseURL','localhost:8080');
> 
> my $opac_base_url = C4::Context->preference('OpacBaseURL');
>+my $staff_base_url = C4::Context->preference('staffClientBaseURL');
> my $query_string = 'ticket=foo&bar=baz';
> 
> $ENV{QUERY_STRING} = $query_string;
>@@ -50,10 +52,17 @@ my $cgi = new CGI($query_string);
> $cgi->delete('ticket');
> 
> # _url_with_get_params tests
>-is(C4::Auth_with_cas::_url_with_get_params($cgi),
>+is(C4::Auth_with_cas::_url_with_get_params($cgi, 'opac'),
>     "$opac_base_url/cgi-bin/koha/opac-user.pl?bar=baz",
>    "_url_with_get_params should return URL without deleted parameters (Bug 12398)");
> 
>+# intranet url test
>+is(C4::Auth_with_cas::_url_with_get_params($cgi, 'intranet'),
>+    "$staff_base_url?bar=baz",
>+   "Intranet URL should be returned when using intranet login (Bug 13507)");
>+
>+
>+
> $dbh->rollback;
> 
> 1;
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13507: 34906 | 34907 | 36316 | 36317 | 36321 | 36339 | 36341 | 36348 | 36349 | 36671 | 36672 | 37431