Attachment 36682 Details for Bug 7677 – Bug 7677: Fix tests

[patch] Bug 7677: Fix tests

Bug-7677-Fix-tests.patch (text/plain), 2.18 KB, created by Brendan Gallagher on 2015-03-06 11:13:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Gallagher

Created: 2015-03-06 11:13:35 UTC

Size: 2.18 KB

patch

obsolete

>From be1d09c43b65612154e020240c687c590f6ed5a1 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 23 Dec 2014 16:51:41 +0100
>Subject: [PATCH] Bug 7677: Fix tests
>
>They don't pass since bug 12098 has been pushed.
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>
>http://bugs.koha-community.org/show_bug.cgi?id=7767
>---
> t/db_dependent/Serials_2.t |   18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/t/db_dependent/Serials_2.t b/t/db_dependent/Serials_2.t
>index 88f507f..b3a74db 100644
>--- a/t/db_dependent/Serials_2.t
>+++ b/t/db_dependent/Serials_2.t
>@@ -1,7 +1,7 @@
> #!/usr/bin/perl
> use Modern::Perl;
> 
>-use Test::More tests => 36;
>+use Test::More tests => 40;
> 
> use MARC::Record;
> 
>@@ -205,14 +205,14 @@ is( C4::Serials::can_show_subscription($subscription_from_another_branch), 1,
> );
> 
> # GetPreviousSerialid
>-my $serialid1 = NewIssue( 1, $subscriptionid, $biblionumber, 2 );
>-my $serialid2 = NewIssue( 2, $subscriptionid, $biblionumber, 2 );
>-my $serialid3 = NewIssue( 3, $subscriptionid, $biblionumber, 2 );
>-
>-is( GetPreviousSerialid( $subscriptionid ), $serialid2, "get previous serialid without parameter");
>-is( GetPreviousSerialid( $subscriptionid, 1 ), $serialid2, "get previous serialid with 1" );
>-is( GetPreviousSerialid( $subscriptionid, 2 ), $serialid1, "get previous serialid with 2" );
>-is( GetPreviousSerialid( $subscriptionid, 3 ), undef, "get previous serialid with 3, does not exist" );
>+my $serialid1 = NewIssue( 1, $subscriptionid_from_my_branch, $biblionumber, 2 );
>+my $serialid2 = NewIssue( 2, $subscriptionid_from_my_branch, $biblionumber, 2 );
>+my $serialid3 = NewIssue( 3, $subscriptionid_from_my_branch, $biblionumber, 2 );
>+
>+is( GetPreviousSerialid( $subscriptionid_from_my_branch ), $serialid2, "get previous serialid without parameter");
>+is( GetPreviousSerialid( $subscriptionid_from_my_branch, 1 ), $serialid2, "get previous serialid with 1" );
>+is( GetPreviousSerialid( $subscriptionid_from_my_branch, 2 ), $serialid1, "get previous serialid with 2" );
>+is( GetPreviousSerialid( $subscriptionid_from_my_branch, 3 ), undef, "get previous serialid with 3, does not exist" );
> 
> $dbh->rollback;
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 7677: 16339 | 16425 | 16456 | 20537 | 20538 | 24099 | 24635 | 25980 | 25981 | 25983 | 27774 | 28950 | 28951 | 28952 | 28953 | 29570 | 29571 | 29572 | 34220 | 34221 | 34222 | 34223 | 34665 | 36389 | 36446 | 36448 | 36449 | 36450 | 36451 | 36452 | 36453 | 36679 | 36680 | 36681 | 36682 | 36683 | 42923 | 42924 | 45938 | 45939 | 45940 | 45941 | 45942 | 45943 | 46216 | 47475 | 52010 | 54876 | 55000 | 55323 | 55466 | 55467 | 55468 | 55469 | 55470 | 55471 | 55472 | 55473 | 55474 | 55475