Attachment 36761 Details for Bug 12072 – [SIGNED-OFF] Bug 12072 - Step 1: Add system preference for New dateformat dd.mm.yyyy

[patch] [SIGNED-OFF] Bug 12072 - Step 1: Add system preference for New dateformat dd.mm.yyyy

SIGNED-OFF-Bug-12072---Step-1-Add-system-preferenc.patch (text/plain), 3.82 KB, created by Bernardo Gonzalez Kriegel on 2015-03-10 11:51:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2015-03-10 11:51:18 UTC

Size: 3.82 KB

patch

obsolete

>From f7b023b096dbbf647dd962920700e8ff5b64de1d Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Sat, 7 Mar 2015 08:38:04 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 12072 - Step 1: Add system preference for
> New dateformat dd.mm.yyyy
>
>As a first step, this patch adds a new system preference for the dateformat dd.mm.yyy
>No other changes are made.
>
>To test:
>1. apply the patch
>2. run updatedatabase.pl
>3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save
>4. verify that the value was saved
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>New preference brakes a lot of things, hopefully will be fixed
>on 13813
>No koha-qa errors
>---
> installer/data/mysql/sysprefs.sql                  |    2 +-
> installer/data/mysql/updatedatabase.pl             |    9 +++++++++
> .../en/modules/admin/preferences/i18n_l10n.pref    |    1 +
> 3 files changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 9020b4b..b908694 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -90,7 +90,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('COinSinOPACResults','1','','If ON, use COinS in OPAC search results page.  NOTE: this can slow down search response time significantly','YesNo'),
> ('ConfirmFutureHolds','0','','Number of days for confirming future holds','Integer'),
> ('CurrencyFormat','US','US|FR','Determines the display format of currencies. eg: \'36000\' is displayed as \'360 000,00\'  in \'FR\' or \'360,000.00\'  in \'US\'.','Choice'),
>-('dateformat','us','metric|us|iso','Define global date format (us mm/dd/yyyy, metric dd/mm/yyy, ISO yyyy-mm-dd)','Choice'),
>+('dateformat','us','metric|us|iso|dmydot','Define global date format (us mm/dd/yyyy, metric dd/mm/yyy, ISO yyyy-mm-dd, dmydot dd.mm.yyyy)','Choice'),
> ('DebugLevel','2','0|1|2','Define the level of debugging information sent to the browser when errors are encountered (set to 0 in production). 0=none, 1=some, 2=most','Choice'),
> ('decreaseLoanHighHolds',NULL,'','Decreases the loan period for items with number of holds above the threshold specified in decreaseLoanHighHoldsValue','YesNo'),
> ('decreaseLoanHighHoldsDuration',NULL,'','Specifies a number of days that a loan is reduced to when used in conjunction with decreaseLoanHighHolds','Integer'),
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index bd39629..a2c8a54 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -9804,6 +9804,15 @@ if ( CheckVersion($DBversion) ) {
>     SetVersion($DBversion);
> }
> 
>+$DBversion = "3.19.00.XXX";
>+if(CheckVersion($DBversion)) {
>+    $dbh->do(q{
>+        UPDATE systempreferences SET options = 'metric|us|iso|dmydot', explanation = 'Define global date format (us mm/dd/yyyy, metric dd/mm/yyy, ISO yyyy-mm-dd, DMY separated by dots dd.mm.yyyy)' WHERE variable = 'dateformat'
>+    });
>+    print "Upgrade to $DBversion done (Bug 12072 - New dateformat dd.mm.yyyy)\n";
>+    SetVersion($DBversion);
>+}
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref
>index dde2f09..cc4118c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref
>@@ -6,6 +6,7 @@ I18N/L10N:
>           choices:
>               us: mm/dd/yyyy
>               metric: dd/mm/yyyy
>+              dmydot: dd.mm.yyyy
>               iso: yyyy-mm-dd
>         - . <b>Note:</b> Do not change this preference on a production server with overdue items that are accruing fines. Doing so will result in duplicate fines!
>     -
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 12072: 27068 | 27069 | 27082 | 27107 | 27108 | 27109 | 27118 | 27130 | 36726 | 36761 | 43317 | 43318 | 44463 | 44606 | 44747 | 44964 | 44966 | 44980 | 45020 | 45022