Attachment 36816 Details for Bug 13794 – Bug 13794: Text input field values not translated

[patch] Bug 13794: Text input field values not translated

Bug-13794-Text-input-field-values-not-translated.patch (text/plain), 1.65 KB, created by Jonathan Druart on 2015-03-11 16:14:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-03-11 16:14:55 UTC

Size: 1.65 KB

patch

obsolete

>From b361511a3bd848ea7bdb604de61b2bbf4916f692 Mon Sep 17 00:00:00 2001
>From: mxbeaulieu <maxime.beaulieu@inlibro.com>
>Date: Thu, 5 Mar 2015 16:56:26 -0500
>Subject: [PATCH] Bug 13794: Text input field values not translated
>
>I left the code logic intact, and simply removed "text" from the regex.
>Text input field values are now translated, no other logical changes are introduced.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Test:
>1) Update, install and enable es-ES language
>2) Go to Reports > Acquisition wizard
>3) On page bottom, there is a text field with the word 'Export'
>4) Switch language, the word is not translated
>5) Apply the patch
>6) Update and install again es-ES language
>7) Reload page, text now reads 'Exportar'
>
>No koha-qa errors.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> misc/translator/tmpl_process3.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/translator/tmpl_process3.pl b/misc/translator/tmpl_process3.pl
>index cb671ae..4ded16f 100755
>--- a/misc/translator/tmpl_process3.pl
>+++ b/misc/translator/tmpl_process3.pl
>@@ -64,7 +64,7 @@ sub text_replace_tag ($$) {
>     if ($attr->{$a}) {
>         next if $a eq 'label' && $tag ne 'optgroup';
>         next if $a eq 'content' && $tag ne 'meta';
>-        next if $a eq 'value' && ($tag ne 'input' || (ref $attr->{'type'} && $attr->{'type'}->[1] =~ /^(?:checkbox|hidden|radio|text)$/)); # FIXME
>+        next if $a eq 'value' && ($tag ne 'input' || (ref $attr->{'type'} && $attr->{'type'}->[1] =~ /^(?:checkbox|hidden|radio)$/)); # FIXME
> 
>         my($key, $val, $val_orig, $order) = @{$attr->{$a}}; #FIXME
>         if ($val =~ /\S/s) {
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13794: 36514 | 36635 | 36637 | 36767 | 36816