Bugzilla – Attachment 36822 Details for
Bug 11430
Search history: Delete selected lines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11430: (QA followup) we test for warnings, always
Bug-11430-QA-followup-we-test-for-warnings-always.patch (text/plain), 1.33 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-03-11 18:11:31 UTC
(
hide
)
Description:
Bug 11430: (QA followup) we test for warnings, always
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-03-11 18:11:31 UTC
Size:
1.33 KB
patch
obsolete
>From 14bbccfcaa2026df508e4e40035dc636a11cb6a2 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 11 Mar 2015 15:10:53 -0300 >Subject: [PATCH] Bug 11430: (QA followup) we test for warnings, always > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > t/db_dependent/Search/History.t | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Search/History.t b/t/db_dependent/Search/History.t >index 5cd0c77..68fde9d 100644 >--- a/t/db_dependent/Search/History.t >+++ b/t/db_dependent/Search/History.t >@@ -2,7 +2,8 @@ > > use Modern::Perl; > >-use Test::More tests => 18; >+use Test::More tests => 19; >+use Test::Warn; > use URI::Escape; > use List::Util qw( shuffle ); > >@@ -123,7 +124,10 @@ is( scalar(@$all), 0, 'There are 0 search after deleting all searches for a user > delete_all( $userid ); > > add( $userid, $current_sessionid, $previous_sessionid, $total, $query_cgi_b, $query_cgi_a ); >-C4::Search::History::delete({}); >+warning_like { C4::Search::History::delete({}) } >+ qr/^ERROR: userid or id is required for history deletion/, >+ 'Calling delete without userid raises warning' >+ ; > $all = C4::Search::History::get({userid => $userid}); > is( scalar(@$all), 9, 'There are still 9 searches after calling delete without userid' ); > delete_all( $userid ); >-- >2.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11430
:
23713
|
23714
|
23715
|
23716
|
23717
|
23718
|
25499
|
25500
|
25501
|
25502
|
25503
|
25504
|
25618
|
28636
|
28637
|
28638
|
28639
|
28640
|
28641
|
28642
|
29042
|
29043
|
29044
|
29045
|
29046
|
29047
|
29048
|
29059
|
29081
|
29082
|
29083
|
29084
|
29085
|
29106
|
29107
|
29108
|
29109
|
29110
|
29592
|
29635
|
29636
|
29637
|
29638
|
29639
|
29640
|
33831
|
33832
|
33833
|
33834
|
33835
|
33836
|
36444
|
36820
|
36821
| 36822