Attachment 36868 Details for Bug 13814 – [PASSED QA] Bug 13814 : add 6 unit tests in t/Boolean.t

[patch] [PASSED QA] Bug 13814 : add 6 unit tests in t/Boolean.t

PASSED-QA-Bug-13814--add-6-unit-tests-in-tBooleant.patch (text/plain), 1.61 KB, created by Kyle M Hall (khall) on 2015-03-13 15:02:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-03-13 15:02:09 UTC

Size: 1.61 KB

patch

obsolete

>From 30bff0e861d70896083bfb15873e1b9d3d1feb59 Mon Sep 17 00:00:00 2001
>From: Julian FIOL <julian.fiol@biblibre.com>
>Date: Mon, 9 Mar 2015 17:21:17 +0100
>Subject: [PATCH] [PASSED QA] Bug 13814 : add 6 unit tests in t/Boolean.t
>
>Works as expected.
>Signed-off-by: Marc Veron <veron@veron.ch>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/Boolean.t |    8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
>diff --git a/t/Boolean.t b/t/Boolean.t
>index 0f04913..af81f13 100755
>--- a/t/Boolean.t
>+++ b/t/Boolean.t
>@@ -2,19 +2,25 @@
> use strict;
> use warnings;
> 
>-use Test::More tests => 13;
>+use Test::More tests => 19;
> 
> BEGIN { use_ok( 'C4::Boolean', qw( true_p ) ); }
> 
> is( true_p('0'),     '0', 'recognizes \'0\' as false' );
>+is( true_p('nil'),     '0', 'recognizes \'nil\' as false' );
> is( true_p('false'), '0', 'recognizes \'false\' as false' );
> is( true_p('off'),   '0', 'recognizes \'off\' as false' );
> is( true_p('no'),    '0', 'recognizes \'no\' as false' );
>+is( true_p('n'),    '0', 'recognizes \'n\' as false' );
>+is( true_p('NO'),  '0', 'verified case insensitivity' );
> 
> is( true_p('1'),    '1', 'recognizes \'1\' as true' );
>+is( true_p('-1'),    '1', 'recognizes \'-1\' as true' );
>+is( true_p('t'), '1', 'recognizes \'t\' as true' );
> is( true_p('true'), '1', 'recognizes \'true\' as true' );
> is( true_p('on'),   '1', 'recognizes \'on\' as true' );
> is( true_p('yes'),  '1', 'recognizes \'yes\' as true' );
>+is( true_p('y'),  '1', 'recognizes \'y\' as true' );
> is( true_p('YES'),  '1', 'verified case insensitivity' );
> 
> is( true_p(undef), undef, 'recognizes undefined as not boolean' );
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13814: 36758 | 36765 | 36771 | 36773 | 36774 | 36868 | 36869 | 36891