Bugzilla – Attachment 36909 Details for
Bug 13586
Makefile.PL mentions win32
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13586: Remove some other occurrences
PASSED-QA-Bug-13586-Remove-some-other-occurrences.patch (text/plain), 2.00 KB, created by
Katrin Fischer
on 2015-03-15 23:24:22 UTC
(
hide
)
Description:
[PASSED QA] Bug 13586: Remove some other occurrences
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-03-15 23:24:22 UTC
Size:
2.00 KB
patch
obsolete
>From 7bc83a74ee1b7c7462d02993a35ab97422318523 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 16 Feb 2015 16:33:16 +0100 >Subject: [PATCH] [PASSED QA] Bug 13586: Remove some other occurrences > >Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Makefile.PL | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > >diff --git a/Makefile.PL b/Makefile.PL >index 598e0ed..dc213a4 100644 >--- a/Makefile.PL >+++ b/Makefile.PL >@@ -446,8 +446,6 @@ my %config_defaults = ( > > # set some default configuration options based on OS > # more conditions need to be added for other OS's >-# this should probably also incorporate usage of Win32::GetOSName() and/or Win32::GetOSVersion() >-# to allow for more granular decisions based on which Win32 platform > > warn "Your platform appears to be $^O.\n" if $DEBUG; > >@@ -1202,7 +1200,7 @@ sub get_target_directories { > > my @basedir = File::Spec->splitdir($directories); > >- if ( $^O eq 'cygwin' ) { shift @basedir; unshift @basedir, 'c:'; } # in a cygwin environment, $volume is returned empty >+ if ( $^O eq 'cygwin' ) { shift @basedir; unshift @basedir, 'c:'; } # in a cygwin environment, $volume is returned empty > > my $package = pop @basedir; > >@@ -1379,8 +1377,6 @@ sub display_configuration { > print "perl Makefile.PL\n"; > print "\nor\n\n"; > print "DB_USER=my_koha DOC_DIR=/usr/local/info perl Makefile.PL\n\n"; >- print "If installing on a Win32 platform, be sure to use:\n"; >- print "'dmake -x MAXLINELENGTH=300000'\n\n"; > } > > =head2 find_zebra >@@ -1388,8 +1384,6 @@ sub display_configuration { > Attempt to find Zebra - check user's PATH and > a few other directories for zebrasrv and zebraidx. > >-FIXME: doesn't handle Win32 >- > =cut > > sub find_zebra { >@@ -1411,8 +1405,6 @@ sub find_zebra { > > package MY; > >-# This will have to be reworked in order to accommodate Win32... >- > sub test { > my $self = shift; > my $test = $self->SUPER::test(@_); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13586
:
35318
|
35947
|
35948
|
36697
|
36698
|
36699
|
36907
|
36908
| 36909