Bugzilla – Attachment 36934 Details for
Bug 13836
Koha/Number/Price.pm: format_for_editing fails 3 tests because of leading spaces in output
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 13836: Does not separate symbol and value if symbol is not displayed.
Signed-off-Bug-13836-Does-not-separate-symbol-and-.patch (text/plain), 1.15 KB, created by
Marc Véron
on 2015-03-16 14:58:35 UTC
(
hide
)
Description:
[Signed-off] Bug 13836: Does not separate symbol and value if symbol is not displayed.
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-03-16 14:58:35 UTC
Size:
1.15 KB
patch
obsolete
>From 9d559b215b69f2f5c6ff3c27dc2e89d49d08a5bc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 16 Mar 2015 15:24:02 +0100 >Subject: [PATCH] [Signed-off] Bug 13836: Does not separate symbol and value > if symbol is not displayed. >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch force the separation between the symbol and the value to an >empty string if the symbol is not displayed. > >Tested with locale de_CH.UTF-8, prove t/Prices.t is now successful. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > Koha/Number/Price.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Number/Price.pm b/Koha/Number/Price.pm >index f29fe06..2d563f9 100644 >--- a/Koha/Number/Price.pm >+++ b/Koha/Number/Price.pm >@@ -106,7 +106,7 @@ sub _format_params { > } > > $format_params{p_cs_precedes} = $p_cs_precedes if defined $p_cs_precedes; >- $format_params{p_sep_by_space} = $p_sep_by_space if defined $p_sep_by_space; >+ $format_params{p_sep_by_space} = ( $int_curr_symbol and defined $p_sep_by_space ) ? $p_sep_by_space : 0; > > return \%format_params; > } >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13836
:
36932
|
36934
|
36937