Attachment 37059 Details for Bug 13879 – [Signed-off] Bug 13879: Fix sort on patron search (guarantor and linked to orders)

[patch] [Signed-off] Bug 13879: Fix sort on patron search (guarantor and linked to orders)

Signed-off-Bug-13879-Fix-sort-on-patron-search-gua.patch (text/plain), 2.49 KB, created by Marc Véron on 2015-03-20 16:45:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2015-03-20 16:45:24 UTC

Size: 2.49 KB

patch

obsolete

>From b296781684f3fa246c6c7559767c8c75bc9e3bcb Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Fri, 20 Mar 2015 14:07:03 +0100
>Subject: [PATCH] [Signed-off] Bug 13879: Fix sort on patron search (guarantor
> and linked to orders)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch fixes a regression introduced by bug 13021.
>
>Test plan:
>1/ Go on a child detail page > edit
>2/ Click on "Set a patron" as a guarantor
>3/ Launch a search a confirm that you are able to sort on card, name and
>date of birth.
>Note that the Address column is not sortable (it's a limitation, could
>be fixed later).
>4/ Go on the acquisition module, create an order.
>5/ Click on the "Add user" button.
>6/ Launch a search a confirm that you are able to sort on card, name and
>category
>
>Without patch, I could not sort on names. With patch, sorting works as dexcribed in Test plan
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> .../prog/en/modules/common/patron_search.tt              |   14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>index 3e93899..fd133e4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>@@ -32,8 +32,16 @@ $(document).ready(function(){
>             aoData.push({
>                 'name': 'searchmember',
>                 'value': $("#searchmember_filter").val()
>-            },
>-            {
>+            },{
>+                'name': 'name_sorton',
>+                'value': 'borrowers.surname borrowers.firstname'
>+            },{
>+                'name': 'category_sorton',
>+                'value': 'categories.description',
>+            },{
>+                'name': 'branch_sorton',
>+                'value': 'branches.branchname'
>+            },{
>                 'name': 'template_path',
>                 'value': '[% json_template %]',
>             }
>@@ -58,6 +66,8 @@ $(document).ready(function(){
>             [% FOR column IN columns %]
>                 [% IF column == 'action' %]
>                     { 'mDataProp': 'dt_action', 'bSortable': false }
>+                [% ELSIF column == 'address' %]
>+                    { 'mDataProp': 'dt_address', 'bSortable': false }
>                 [% ELSE %]
>                     { 'mDataProp': 'dt_[% column %]' }
>                 [% END %]
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13879: 37040 | 37059 | 37072