Attachment 37145 Details for Bug 2542 – Bug 2542: Validate the amount of a manual invoice/create

[patch] Bug 2542: Validate the amount of a manual invoice/create

Bug-2542-Validate-the-amount-of-a-manual-invoicecr.patch (text/plain), 2.94 KB, created by Jonathan Druart on 2015-03-23 16:09:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-03-23 16:09:18 UTC

Size: 2.94 KB

patch

obsolete

>From d89e7d9fd9b02f005729adfaf3feddc18778991b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 18 Mar 2015 16:49:52 +0100
>Subject: [PATCH] Bug 2542: Validate the amount of a manual invoice/create
>
>If a manual invoice/credit amount is not correctly set, it should not be
>accepted.
>
>Test plan:
>Try to create a manual invoice and a manual credit with an amount containing
>something else than numbers.
>It should not be possible.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt  | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>index 13500ab..a17764d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
>@@ -45,7 +45,7 @@ $(document).ready(function(){
> 	<li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li>
> 	<li><label for="desc">Description: </label><input type="text" name="desc" size="50" id="desc" /></li>
>     <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li>
>-	<li><label for="amount">Amount: </label><input type="text" name="amount" id="amount" /> Example: 5.00</li>
>+    <li><label for="amount">Amount: </label><input type="number" name="amount" id="amount" required="required" value="0" step="any" min="0" /> Example: 5.00</li>
> </ol></fieldset>
> 
> <fieldset class="action"><input type="submit" name="add" value="Add credit" /> <a class="cancel" href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% borrowernumber %]">Cancel</a></fieldset>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>index 445fffe..520eb2d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>@@ -69,7 +69,7 @@ type_fees['[% invoice_types_loo.authorised_value %]'] = "[% invoice_types_loo.li
> 	<li><label for="barcode">Barcode: </label><input type="text" name="barcode" id="barcode" /></li>
> 	<li><label for="desc">Description: </label><input type="text" name="desc" id="desc" size="50" /></li>
>     <li><label for="note">Note: </label><input type="text" name="note" size="50" id="note" /></li>
>-	<li><label for="amount">Amount: </label><input type="text" name="amount" id="amount" /> Example: 5.00</li>
>+    <li><label for="amount">Amount: </label><input type="number" name="amount" id="amount" required="required" value="0" step="any" min="0" /> Example: 5.00</li>
> 	</ol></fieldset>
> <fieldset class="action"><input type="submit" name="add" value="Save" /> <a class="cancel" href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% borrowernumber %]">Cancel</a></fieldset>
> </form>
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 2542: 36989 | 36990 | 37145 | 37166 | 37202 | 37538 | 37555 | 37556