Bugzilla – Attachment 37199 Details for
Bug 13898
Remove unused code in moremember.pl related to permission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13898: Remove CANDELETEUSER code
PASSED-QA-Bug-13898-Remove-CANDELETEUSER-code.patch (text/plain), 2.02 KB, created by
Katrin Fischer
on 2015-03-24 21:47:38 UTC
(
hide
)
Description:
[PASSED QA] Bug 13898: Remove CANDELETEUSER code
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-03-24 21:47:38 UTC
Size:
2.02 KB
patch
obsolete
>From e50eb83d0682d4acca814948f4c912caa2df296d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 24 Mar 2015 10:55:50 +0100 >Subject: [PATCH] [PASSED QA] Bug 13898: Remove CANDELETEUSER code >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This code is never used. The permission to delete a patron is now done >in members-toolbar.inc using CAN_user_borrowers. >It's the good way to do. > >Test plan: > git grep CANDELETEUSER >should not return any result > >Followed test plan. No CANDELETEUSER found. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > members/moremember.pl | 18 ------------------ > 1 file changed, 18 deletions(-) > >diff --git a/members/moremember.pl b/members/moremember.pl >index 92fe2d9..7dc7ef3 100755 >--- a/members/moremember.pl >+++ b/members/moremember.pl >@@ -277,23 +277,6 @@ foreach (@$alerts) { > $_->{relatedto} = findrelatedto( $_->{type}, $_->{externalid} ); > } > >-my $candeleteuser; >-my $userenv = C4::Context->userenv; >-if ( C4::Context->IsSuperLibrarian() ) { >- $candeleteuser = 1; >-} >-elsif ( C4::Context->preference("IndependentBranches") ) { >- $candeleteuser = ( $data->{'branchcode'} eq $userenv->{branch} ); >-} >-else { >- if ( C4::Auth::getuserflags( $userenv->{flags}, $userenv->{number} )->{borrowers} ) { >- $candeleteuser = 1; >- } >- else { >- $candeleteuser = 0; >- } >-} >- > # Add sync data to the user data > if ( C4::Context->preference('NorwegianPatronDBEnable') && C4::Context->preference('NorwegianPatronDBEnable') == 1 ) { > my $sync = NLGetSyncDataFromBorrowernumber( $borrowernumber ); >@@ -360,7 +343,6 @@ $template->param( $data->{'categorycode'} => 1 ); > $template->param( > detailview => 1, > AllowRenewalLimitOverride => C4::Context->preference("AllowRenewalLimitOverride"), >- CANDELETEUSER => $candeleteuser, > roadtype => $roadtype, > borrowernumber => $borrowernumber, > othernames => $data->{'othernames'}, >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13898
:
37167
|
37169
| 37199