Bugzilla – Attachment 37221 Details for
Bug 6178
tag cloud diff depends on where you click
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 6178: Display tags from other users in all cases.
Signed-off-Bug-6178-Display-tags-from-other-users-.patch (text/plain), 2.71 KB, created by
Marc Véron
on 2015-03-25 15:19:11 UTC
(
hide
)
Description:
[Signed-off] Bug 6178: Display tags from other users in all cases.
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-03-25 15:19:11 UTC
Size:
2.71 KB
patch
obsolete
>From e03d73cf222a68926aad5d239605ad14afb87be1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 25 Mar 2015 14:00:39 +0100 >Subject: [PATCH] [Signed-off] Bug 6178: Display tags from other users in all > cases. >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >At the OPAC, if you click on the "your tags" link, only you tags are >displayed in the tag cloud. > >There is no sense to do that, the user's tags are displayed in the table >below. > >Test plan: >Confirm that you see all tags in the tag cloud, even if you click on the >"your tags" link. > >Patch behaves as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc | 2 +- > opac/opac-tags.pl | 6 ++---- > 2 files changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc >index 182543b..4c2c913 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc >@@ -29,7 +29,7 @@ > [% ELSE %] > <li> > [% END %] >- <a href="/cgi-bin/koha/opac-tags.pl?mine=1">your tags</a></li> >+ <a href="/cgi-bin/koha/opac-tags.pl">your tags</a></li> > [% END %] > > [% IF ( OpacPasswordChange ) %] >diff --git a/opac/opac-tags.pl b/opac/opac-tags.pl >index 6388a01..157bfd3 100755 >--- a/opac/opac-tags.pl >+++ b/opac/opac-tags.pl >@@ -253,14 +253,12 @@ if ($add_op) { > deleted_count => $dels, > ); > } else { >- my ($arg,$limit,$mine); >+ my ($arg,$limit); > my $hardmax = 100; # you might disagree what this value should be, but there definitely should be a max > $limit = $query->param('limit') || $hardmax; >- $mine = $query->param('mine') || 0; # set if the patron want to see only his own tags. > ($limit =~ /^\d+$/ and $limit <= $hardmax) or $limit = $hardmax; > $template->param(limit => $limit); > my $arghash = {approved=>1, limit=>$limit, 'sort'=>'-weight_total'}; >- $arghash->{'borrowernumber'} = $loggedinuser if $mine; > # ($openadds) or $arghash->{approved} = 1; > if ($arg = $query->param('tag')) { > $arghash->{term} = $arg; >@@ -270,7 +268,7 @@ if ($add_op) { > $results = get_approval_rows($arghash); > stratify_tags(10, $results); # work out the differents sizes for things > my $count = scalar @$results; >- $template->param(TAGLOOP_COUNT => $count, mine => $mine); >+ $template->param(TAGLOOP_COUNT => $count); > } > (scalar @errors ) and $template->param(ERRORS => \@errors); > my @orderedresult = sort { uc($a->{'term'}) cmp uc($b->{'term'}) } @$results; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6178
:
3907
|
3908
|
37213
| 37221