Attachment 37309 Details for Bug 13890 – [PASSED QA] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists

[patch] [PASSED QA] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists

PASSED-QA-Bug-13890---Switch-from-full-serials-per.patch (text/plain), 1.81 KB, created by Kyle M Hall (khall) on 2015-03-27 12:38:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-03-27 12:38:49 UTC

Size: 1.81 KB

patch

obsolete

>From 9be9a7983a90a37be2d41411b9d7234c3ab6c3e9 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Sun, 22 Mar 2015 22:07:32 +0100
>Subject: [PATCH] [PASSED QA] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists
>
>For changing the sequence of patrons on a routing list by changing
>one of the numbers via the pull downs, full serial permission is needed:
>
>To test:
>- Give your patron full serial permissions
>- Create a subscription and a routing list for it
>- Change the sequence on the routing list using the pull downs
>- Verify this works
>- Remove any of the serial sub permissions (claim serials or similar)
>- Verify changing the sequence now results in a permission error
>- Apply patch
>- Verify that the permission error is gone now
>- Remove the routing permission
>- Verify the permission error is back (but this seems to make sense)
>
>In general more fixes would be required to make all routing related
>features depend on the routing permission, but I think this fixes
>the bug making it depend on the correct permission.
>
>Followed test plan. Works as expected.
>Signed-off-by: Marc Veron <veron@veron.ch>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> serials/reorder_members.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/serials/reorder_members.pl b/serials/reorder_members.pl
>index ba19b8c..9ff633c 100755
>--- a/serials/reorder_members.pl
>+++ b/serials/reorder_members.pl
>@@ -29,7 +29,7 @@ my $subscriptionid = $query->param('subscriptionid');
> my $routingid      = $query->param('routingid');
> my $rank           = $query->param('rank');
> 
>-checkauth( $query, 0, { serials => 1 }, 'intranet' );
>+checkauth( $query, 0, { serials => 'routing' }, 'intranet' );
> 
> reorder_members( $subscriptionid, $routingid, $rank );
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13890: 37096 | 37099 | 37309