Bugzilla – Attachment 37317 Details for
Bug 5844
Unhighlight cuts off some strings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 5844: Avoid strings cut on unhighlighing
PASSED-QA-Bug-5844-Avoid-strings-cut-on-unhighligh.patch (text/plain), 1.96 KB, created by
Kyle M Hall (khall)
on 2015-03-27 13:54:11 UTC
(
hide
)
Description:
[PASSED QA] Bug 5844: Avoid strings cut on unhighlighing
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-03-27 13:54:11 UTC
Size:
1.96 KB
patch
obsolete
>From ce9e1aea23aedc264ae69fc57a0616905cd0aa94 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 26 Mar 2015 10:23:26 +0100 >Subject: [PATCH] [PASSED QA] Bug 5844: Avoid strings cut on unhighlighing > >If a user is searching for several words and that one is contained in >another ( "mag ma" ), some characters are cut (removed from the DOM!). > >To reproduce: >1/ search for "mag ma m" >2/ The result page contains "Magazine" >3/ "Mag" is highlighted >4/ Click on the "Unhighlight" link >5/ The "Magazine" words become "azine", "Mag" has been cut. >There is no way to show these characters again. > >Test plan: >1/ Confirm the bad behavior without this patch >2/ Apply this patch >3/ search for "mag ma m" >4/ The result page contains "Magazine" >5/ "Mag" is highlighted >6/ Click on the "Unhighlight" link >7/ strings are unhighlighted and still in the DOM :) > >Note that the Highlight link won't work very well (only "a" will be >highlighted, but considered as minor since this did not work before the >patch neither). > >Followed test plan. Strings are no longer cut when unhiglighted. >Signed-off-by: Marc Veron <veron@veron.ch> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../lib/jquery/plugins/jquery.highlight-3.js | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js b/koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js >index 69bb52d..8eabca4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js >@@ -44,10 +44,6 @@ jQuery.fn.highlight = function(pat) { > > jQuery.fn.removeHighlight = function() { > return this.find("span.term").each(function() { >- this.parentNode.firstChild.nodeName; >- with (this.parentNode) { >- replaceChild(this.firstChild, this); >- normalize(); >- } >- }).end(); >+ $(this).contents().unwrap(); >+ }); > }; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5844
:
37273
|
37282
| 37317