Bugzilla – Attachment 37322 Details for
Bug 3873
Gracefully handle errors when item in staff client cart has been deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 3873: Avoid software error if the cart contains a deleted record
PASSED-QA-Bug-3873-Avoid-software-error-if-the-car.patch (text/plain), 1.30 KB, created by
Kyle M Hall (khall)
on 2015-03-27 14:35:22 UTC
(
hide
)
Description:
[PASSED QA] Bug 3873: Avoid software error if the cart contains a deleted record
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-03-27 14:35:22 UTC
Size:
1.30 KB
patch
obsolete
>From dfbeca7bd4e1684f2c7d564212547973b7eea5bf Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 25 Mar 2015 09:39:02 +0100 >Subject: [PATCH] [PASSED QA] Bug 3873: Avoid software error if the cart contains a deleted record > >If a record is placed in the basket and deleted, the basket view >exploded with: >Can't use an undefined value as an ARRAY reference at >/home/koha/src/basket/basket.pl line 73. > >Test plan: >1/ Add some records to the basket >2/ Delete one of them >3/ Look at your basket >It should not exploded > >Note that the number of items in the basket is now wrong. > >Works as expected. >Signed-off-by: Marc Veron <veron@veron.ch> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > basket/basket.pl | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >diff --git a/basket/basket.pl b/basket/basket.pl >index ea8e863..83440fd 100755 >--- a/basket/basket.pl >+++ b/basket/basket.pl >@@ -61,6 +61,7 @@ foreach my $biblionumber ( @bibs ) { > $template->param( biblionumber => $biblionumber ); > > my $dat = &GetBiblioData($biblionumber); >+ next unless $dat; > my $record = &GetMarcBiblio($biblionumber); > my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3873
:
37205
|
37208
|
37219
|
37220
| 37322 |
37323