Bugzilla – Attachment 37323 Details for
Bug 3873
Gracefully handle errors when item in staff client cart has been deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 3873: follow-up for all other pages
PASSED-QA-Bug-3873-follow-up-for-all-other-pages.patch (text/plain), 2.64 KB, created by
Kyle M Hall (khall)
on 2015-03-27 14:36:01 UTC
(
hide
)
Description:
[PASSED QA] Bug 3873: follow-up for all other pages
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-03-27 14:36:01 UTC
Size:
2.64 KB
patch
obsolete
>From fdf38158bb6545916d2a9ea867a80ad39e8e4fa1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 25 Mar 2015 15:51:00 +0100 >Subject: [PATCH] [PASSED QA] Bug 3873: follow-up for all other pages > >This should fix the issue on other pages. > >Test plan: >Try to download and export the basket (intranet+opac sides). > >Re-tested for errors in comment #5, they do not longer appear. >Signed-off-by: Marc Veron <veron@veron.ch> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > basket/downloadcart.pl | 1 + > basket/sendbasket.pl | 1 + > opac/opac-basket.pl | 1 + > opac/opac-sendbasket.pl | 1 + > 4 files changed, 4 insertions(+), 0 deletions(-) > >diff --git a/basket/downloadcart.pl b/basket/downloadcart.pl >index 199271e..2d2ceb8 100755 >--- a/basket/downloadcart.pl >+++ b/basket/downloadcart.pl >@@ -66,6 +66,7 @@ if ($bib_list && $format) { > foreach my $biblio (@bibs) { > > my $record = GetMarcBiblio($biblio, 1); >+ next unless $record; > > if ($format eq 'iso2709') { > $output .= $record->as_usmarc(); >diff --git a/basket/sendbasket.pl b/basket/sendbasket.pl >index 9c3e6a5..0614aa3 100755 >--- a/basket/sendbasket.pl >+++ b/basket/sendbasket.pl >@@ -72,6 +72,7 @@ if ( $email_add ) { > $template2->param( biblionumber => $biblionumber ); > > my $dat = GetBiblioData($biblionumber); >+ next unless $dat; > my $record = GetMarcBiblio($biblionumber, 1); > my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); >diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl >index 2b345e1..b374f3c 100755 >--- a/opac/opac-basket.pl >+++ b/opac/opac-basket.pl >@@ -63,6 +63,7 @@ foreach my $biblionumber ( @bibs ) { > $template->param( biblionumber => $biblionumber ); > > my $dat = &GetBiblioData($biblionumber); >+ next unless $dat; > my $record = &GetMarcBiblio($biblionumber); > next unless $record; > my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); >diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl >index d0aa34a..551ee1c 100755 >--- a/opac/opac-sendbasket.pl >+++ b/opac/opac-sendbasket.pl >@@ -87,6 +87,7 @@ if ( $email_add ) { > $template2->param( biblionumber => $biblionumber ); > > my $dat = GetBiblioData($biblionumber); >+ next unless $dat; > my $record = GetMarcBiblio($biblionumber, 1); > my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3873
:
37205
|
37208
|
37219
|
37220
|
37322
| 37323